Proposal: set libvirt connection uri with node selector#45
Closed
PhilippMatthes wants to merge 1 commit intomainfrom
Closed
Proposal: set libvirt connection uri with node selector#45PhilippMatthes wants to merge 1 commit intomainfrom
PhilippMatthes wants to merge 1 commit intomainfrom
Conversation
PhilippMatthes
changed the title
Member
Author
|
Superseded by a different solution in #52 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes use of the
nova.openstack.cloud.sap/virt-driverlabel provided to kvm nodes and maps this to the corresponding libvirt connection string, which is then provided as env to the controller manager. This will allow the libvirt component to auto-discover hypervisor information correctly.