feat: upgrade to Rails 8.1 #386
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BuonOmo
force-pushed
the
feat/rails-8-1
branch
2 times, most recently
from
cb4869f to
d8e3e07
Compare
BuonOmo
force-pushed
the
feat/rails-8-1
branch
from
d8e3e07 to
f9b1c88
Compare
Rails is moving towards ractor compatibility, and to do so it swapped to frozen database objects. Hence we cannot simply memoize the factories anymore. I've checked the initialization speed for factories, and the memoization was too fast for it to be worth implementing a cache. See rails/rails@d2da816 See rails/rails@76448a0
BuonOmo
force-pushed
the
feat/rails-8-1
branch
from
f157af7 to
0cf5c83
Compare
- update some outdated overrides. - update override comments to know when was the last override. - remove the `#column_names_from_column_numbers` method that was generating N+1 queries. - update related methods. See: - rails/rails@249c367 - rails/rails@4e0546c - rails/rails@c93d1b0
BuonOmo
force-pushed
the
feat/rails-8-1
branch
from
ab74ce6 to
dc9a906
Compare
BuonOmo
commented
Oct 30, 2025
| # | ||
| # @see: https://github.com/rails/rails/blob/8695b028261bdd244e254993255c6641bdbc17a5/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb#L829 | ||
| # OVERRIDE(v8.1.1): | ||
| # - comment is retrieved differently than PG for performance |
There was a problem hiding this comment.
col_description is the method used to retrieve the comment in PG. @rafiss is still true that this is slower than using information_schema.columns ?
BuonOmo
commented
Oct 30, 2025
Comment on lines
+38
to
+42
| ARRAY( | ||
| SELECT a.attname | ||
| FROM pg_attribute a | ||
| WHERE a.attrelid = d.indexrelid AND a.attishidden | ||
| ) AS hidden_columns |
There was a problem hiding this comment.
@rafiss
I added this bit. I'm really unsure about performances, any better idea would be appreciated.
The goal is to remove hidden columns from the columns above. My main issue was that we are using pg_get_indexdef to retrieve the columns. I don't know edge cases so I was not eager to use another method, but if we were not to use it I feel like we could easily have a faster and simpler approach.
My second question is: do you have a simple routine to benchmark two slightly different columns in CRDB, and pitfalls I should avoid?
EDIT: one of the ideas I had:
ARRAY(
SELECT a.attname
FROM pg_attribute a
JOIN unnest(d.indkey) AS k(attnum)
ON a.attrelid = d.indrelid AND a.attnum = k.attnum
AND NOT a.attishidden
) AS visible_columns
BuonOmo
force-pushed
the
feat/rails-8-1
branch
from
12da876 to
1ec2c3a
Compare
BuonOmo
force-pushed
the
feat/rails-8-1
branch
from
1ec2c3a to
a3bc3d5
Compare
BuonOmo
force-pushed
the
feat/rails-8-1
branch
from
203097e to
35a1516
Compare
BuonOmo
force-pushed
the
feat/rails-8-1
branch
from
35a1516 to
bfa5262
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs:
#foreign_keysworks if t2 doesn't belong to the same namespace as t1