docgen: expose WITH/WITHOUT HOLD syntax in SQL cursor diagram #146458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
DrewKimball
approved these changes
May 9, 2025
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @taroface)
|
bors r=DrewKimball |
craig bot
pushed a commit
that referenced
this pull request
May 9, 2025
146458: docgen: expose WITH/WITHOUT HOLD syntax in SQL cursor diagram r=DrewKimball a=taroface This PR exposes the WITH HOLD / WITHOUT HOLD syntax in the DECLARE ... CURSOR diagram as follows: <img width="903" alt="image" src="https://github.com/user-attachments/assets/92c448fa-143b-47bb-aa8a-38b68542e123" /> Relates to cockroachdb/docs#19590. Epic: none Release note: none Release justification: non-production code change Co-authored-by: Ryan Kuo <[email protected]>
|
Build failed: |
|
@DrewKimball Can you tell why this build failed? |
|
bors r=DrewKimball |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the WITH HOLD / WITHOUT HOLD syntax in the DECLARE ... CURSOR diagram as follows:
Relates to cockroachdb/docs#19590.
Epic: none
Release note: none
Release justification: non-production code change