telemetryccl: unskip and simplify TestTelemetry #156481
Open
+43
−210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would often get test flakes for TestTelemetry because it exercised many different multi-region features for the sole purpose of checking whether telemetry counters would get incremented. This is not very useful because the logic for the different counters is mostly identical and runs through the same functions in multiregion/telemetry.go. As long as these integration tests verify that those functions get called, we don't need an exhaustive set of cases. Resolves: cockroachdb#152123 Epic: None Release note: none
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would often get test flakes for TestTelemetry because it exercised many different multi-region features for the sole purpose of checking whether telemetry counters would get incremented. This is not very useful because the logic for the different counters is mostly identical and runs through the same functions in multiregion/telemetry.go. As long as these integration tests verify that those functions get called, we don't need an exhaustive set of cases.
Resolves: #152123
Epic: None
Release note: none