Skip to content

Conversation

@jbowens
Copy link
Collaborator

@jbowens jbowens commented Oct 29, 2025

Changes:

  • e8d7ecb3 db: tolerate unknown options
  • 75afc702 vfs: log GetDiskUsage calls in loggingFS
  • 459c8ae8 db: scan and filter WALs during recovery
  • 91dfeada db: move locking of WAL recovery directories
  • 15d065ba db: fix RangeDeletionBytesEstimate
  • c26a7b21 db: add RangeDeletionBytesEstimate blob file test
  • 580eb1a8 db,valsep: move valsep tests to appropriate pkg

Release note: none.
Epic: none.

@jbowens jbowens requested review from a team and annrpom October 29, 2025 21:04
@jbowens jbowens requested a review from a team as a code owner October 29, 2025 21:04
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jbowens jbowens force-pushed the jackson/pebble-master-e8d7ecb38559 branch from e550008 to 62ff53b Compare October 29, 2025 22:37
@jbowens jbowens requested review from a team as code owners October 29, 2025 22:37
Changes:

 * [`e8d7ecb3`](cockroachdb/pebble@e8d7ecb3) db: tolerate unknown options
 * [`75afc702`](cockroachdb/pebble@75afc702) vfs: log GetDiskUsage calls in loggingFS
 * [`459c8ae8`](cockroachdb/pebble@459c8ae8) db: scan and filter WALs during recovery
 * [`91dfeada`](cockroachdb/pebble@91dfeada) db: move locking of WAL recovery directories
 * [`15d065ba`](cockroachdb/pebble@15d065ba) db: fix RangeDeletionBytesEstimate
 * [`c26a7b21`](cockroachdb/pebble@c26a7b21) db: add RangeDeletionBytesEstimate blob file test
 * [`580eb1a8`](cockroachdb/pebble@580eb1a8) db,valsep: move valsep tests to appropriate pkg

Release note: none.
Epic: none.
@jbowens jbowens force-pushed the jackson/pebble-master-e8d7ecb38559 branch from 62ff53b to 97071d2 Compare October 30, 2025 14:48
@jbowens
Copy link
Collaborator Author

jbowens commented Oct 30, 2025

TFTR!

bors r=annrpom

craig bot pushed a commit that referenced this pull request Oct 30, 2025
156492: go.mod: bump Pebble to e8d7ecb38559 r=annrpom a=jbowens

Changes:

 * [`e8d7ecb3`](cockroachdb/pebble@e8d7ecb3) db: tolerate unknown options
 * [`75afc702`](cockroachdb/pebble@75afc702) vfs: log GetDiskUsage calls in loggingFS
 * [`459c8ae8`](cockroachdb/pebble@459c8ae8) db: scan and filter WALs during recovery
 * [`91dfeada`](cockroachdb/pebble@91dfeada) db: move locking of WAL recovery directories
 * [`15d065ba`](cockroachdb/pebble@15d065ba) db: fix RangeDeletionBytesEstimate
 * [`c26a7b21`](cockroachdb/pebble@c26a7b21) db: add RangeDeletionBytesEstimate blob file test
 * [`580eb1a8`](cockroachdb/pebble@580eb1a8) db,valsep: move valsep tests to appropriate pkg

Release note: none.
Epic: none.

156510: *: remove stale skips of test tenant randomization r=yuzefovich a=yuzefovich

I've audited all places where we disable test tenants in some way and found a handful of places where an already closed issue was used as a reference for why a particular test disables test tenants. This commit removes those now-stale skips.

Epic: CRDB-48945
Release note: None

Co-authored-by: Jackson Owens <[email protected]>
Co-authored-by: Yahor Yuzefovich <[email protected]>
@craig
Copy link
Contributor

craig bot commented Oct 30, 2025

Build failed (retrying...):

craig bot pushed a commit that referenced this pull request Oct 30, 2025
156492: go.mod: bump Pebble to e8d7ecb38559 r=annrpom a=jbowens

Changes:

 * [`e8d7ecb3`](cockroachdb/pebble@e8d7ecb3) db: tolerate unknown options
 * [`75afc702`](cockroachdb/pebble@75afc702) vfs: log GetDiskUsage calls in loggingFS
 * [`459c8ae8`](cockroachdb/pebble@459c8ae8) db: scan and filter WALs during recovery
 * [`91dfeada`](cockroachdb/pebble@91dfeada) db: move locking of WAL recovery directories
 * [`15d065ba`](cockroachdb/pebble@15d065ba) db: fix RangeDeletionBytesEstimate
 * [`c26a7b21`](cockroachdb/pebble@c26a7b21) db: add RangeDeletionBytesEstimate blob file test
 * [`580eb1a8`](cockroachdb/pebble@580eb1a8) db,valsep: move valsep tests to appropriate pkg

Release note: none.
Epic: none.

Co-authored-by: Jackson Owens <[email protected]>
@craig
Copy link
Contributor

craig bot commented Oct 30, 2025

Build failed:

@jbowens
Copy link
Collaborator Author

jbowens commented Oct 30, 2025

bors retry

craig bot pushed a commit that referenced this pull request Oct 30, 2025
156492: go.mod: bump Pebble to e8d7ecb38559 r=annrpom a=jbowens

Changes:

 * [`e8d7ecb3`](cockroachdb/pebble@e8d7ecb3) db: tolerate unknown options
 * [`75afc702`](cockroachdb/pebble@75afc702) vfs: log GetDiskUsage calls in loggingFS
 * [`459c8ae8`](cockroachdb/pebble@459c8ae8) db: scan and filter WALs during recovery
 * [`91dfeada`](cockroachdb/pebble@91dfeada) db: move locking of WAL recovery directories
 * [`15d065ba`](cockroachdb/pebble@15d065ba) db: fix RangeDeletionBytesEstimate
 * [`c26a7b21`](cockroachdb/pebble@c26a7b21) db: add RangeDeletionBytesEstimate blob file test
 * [`580eb1a8`](cockroachdb/pebble@580eb1a8) db,valsep: move valsep tests to appropriate pkg

Release note: none.
Epic: none.

156565: logictest: reduce data set in cursor test r=yuzefovich a=yuzefovich

We've seen a few failures on `cursor` logic test under race which seems to be due to node overload / timeout. My hypothesis is it's due to metamorphic randomization, and I found one spot where we use 10k rows in the table, but I don't think we need this much. This commit reduces the row count to just 10 in hopes of eliminating the flake under race.

Fixes: #155609.
Release note: None

Co-authored-by: Jackson Owens <[email protected]>
Co-authored-by: Yahor Yuzefovich <[email protected]>
@craig
Copy link
Contributor

craig bot commented Oct 30, 2025

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Oct 30, 2025

@craig craig bot merged commit 4d4d324 into cockroachdb:master Oct 30, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants