Skip to content

cloud/amazon: disable s3.client_retry_token_bucket.enabled by default #156496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
Merged

cloud/amazon: disable s3.client_retry_token_bucket.enabled by default #156496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions pkg/cloud/amazon/s3_storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,9 +173,7 @@ var enableClientRetryTokenBucket = settings.RegisterBoolSetting(
settings.ApplicationLevel,
"cloudstorage.s3.client_retry_token_bucket.enabled",
"enable the client side retry token bucket in the AWS S3 client",
// TODO(jeffswenson): change this to false in a seperate PR. This is false in
// the backports to stay true to the backport policy.
true)
false)

// roleProvider contains fields about the role that needs to be assumed
// in order to access the external storage.
Expand Down