sql: enable test tenants #156504
Open
sql: enable test tenants #156504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuzefovich
requested review from
DrewKimball and
log-head
and removed request for
a team
|
This change is |
yuzefovich
requested review from
a team
and removed request for
a team and
log-head
These were redundant because we have GetRequests in all call sites. Release note: None
yuzefovich
force-pushed
the
tenant-pkg-sql
branch
2 times, most recently
from
a70b974 to
86bc631
Compare
Potential Bug(s) DetectedThe three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation. Next Steps: Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary. After you review the findings, please tag the issue as follows:
|
github-actions
bot
added
the
o-AI-Review-Potential-Issue-Detected
yuzefovich
added
O-AI-Review-Not-Helpful
Some tests have been adjusted to work with test tenants, others have specific issues to investigate further. Release note: None
yuzefovich
force-pushed
the
tenant-pkg-sql
branch
from
86bc631 to
3f64b0e
Compare
DrewKimball
approved these changes
Nov 6, 2025
There was a problem hiding this comment.
@DrewKimball reviewed 3 of 3 files at r1, 35 of 35 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sql: remove some redundant kv.TestingIsRangeLookupRequest calls in tests
These were redundant because we have GetRequests in all call sites.
sql: enable test tenants
Some tests have been adjusted to work with test tenants, others have specific issues to investigate further.
Fixes: #143114
Epic: CRDB-48945