-
Notifications
You must be signed in to change notification settings - Fork 4k
release-25.2: cloud/amazon: disable s3.client_retry_token_bucket.enabled by default #156542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-25.2: cloud/amazon: disable s3.client_retry_token_bucket.enabled by default #156542
Conversation
Disabling the client side retry token bucket has made s3 backups at scale more stable. Epic: none Release note: none
04f73b8 to
edce497
Compare
|
Thanks for opening a backport. Before merging, please confirm that it falls into one of the following categories (select one):
Add a brief release justification to the PR description explaining your selection. Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy. All backports must be reviewed by the TL and EM for the owning area. |
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
✅ PR #156542 is compliant with backport policy Confidence: high 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Backport 1/1 commits from #156496 on behalf of @msbutler.
Disabling the client side retry token bucket has made s3 backups at scale more stable.
Epic: none
Release note: none
Release justification: