Skip to content

Conversation

@RaduBerinde
Copy link
Member

Changes:

  • 36cb7a24 valsep: do not embed sstable.Writer methods on SSTBlobWriter
  • 3735f59e db: change panic to fatalf for better debuggability
  • e494c554 objstorage: move ReadableFile and SimpleReadable form sstable -> objstorage

Release note: none.
Epic: none.

@RaduBerinde RaduBerinde requested a review from xinhaoz December 3, 2025 17:24
@RaduBerinde RaduBerinde requested review from a team as code owners December 3, 2025 17:24
@RaduBerinde RaduBerinde requested review from dt and removed request for a team December 3, 2025 17:24
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Changes:

 * [`36cb7a24`](cockroachdb/pebble@36cb7a24) valsep: do not embed  sstable.Writer methods on SSTBlobWriter
 * [`3735f59e`](cockroachdb/pebble@3735f59e) db: change panic to fatalf for better debuggability
 * [`e494c554`](cockroachdb/pebble@e494c554) objstorage: move ReadableFile and SimpleReadable form sstable -> objstorage

Release note: none.
Epic: none.
@RaduBerinde RaduBerinde force-pushed the radu/pebble-master-36cb7a24d395 branch from 73d0aa8 to b4ca58e Compare December 3, 2025 18:24
@RaduBerinde
Copy link
Member Author

TFTR!

bors r+

craig bot pushed a commit that referenced this pull request Dec 4, 2025
158623: team: delete duplicate `TEAMS.yaml` file r=rail a=rickystewart

There's no reason for this to be checked into the repo twice; the copy in the repo root is sufficient.

Release note: none
Epic: none

158632: ci: ensure we correctly report owners for generated tests r=rail,srosenberg,herkolategan,williamchoe3 a=rickystewart

To do so, generate code before any time where we would be filing issues
to test owners.

Closes: #107885
Release note: none
Epic: CRDB-36213


158689: go.mod: bump Pebble to 36cb7a24d395 r=RaduBerinde a=RaduBerinde

Changes:

 * [`36cb7a24`](cockroachdb/pebble@36cb7a24) valsep: do not embed  sstable.Writer methods on SSTBlobWriter
 * [`3735f59e`](cockroachdb/pebble@3735f59e) db: change panic to fatalf for better debuggability
 * [`e494c554`](cockroachdb/pebble@e494c554) objstorage: move ReadableFile and SimpleReadable form sstable -> objstorage

Release note: none.
Epic: none.

158773: sql/schemachanger: deflake backup and restore tests r=fqazi a=fqazi

Previously, the backup and restore tests could flake locally or on CI because we relied on the second granularity of finished_time. This was not sufficient because tests could execute fast enough so that the status of the latest schema change could be confused. To address this, this patch uses the max job ID to detect newer jobs.

Fixes: #158772
Release note: None

Co-authored-by: Ricky Stewart <[email protected]>
Co-authored-by: Radu Berinde <[email protected]>
Co-authored-by: Faizan Qazi <[email protected]>
@craig
Copy link
Contributor

craig bot commented Dec 4, 2025

Build failed (retrying...):

craig bot pushed a commit that referenced this pull request Dec 4, 2025
158632: ci: ensure we correctly report owners for generated tests r=rail,srosenberg,herkolategan,williamchoe3 a=rickystewart

To do so, generate code before any time where we would be filing issues
to test owners.

Closes: #107885
Release note: none
Epic: CRDB-36213


158689: go.mod: bump Pebble to 36cb7a24d395 r=RaduBerinde a=RaduBerinde

Changes:

 * [`36cb7a24`](cockroachdb/pebble@36cb7a24) valsep: do not embed  sstable.Writer methods on SSTBlobWriter
 * [`3735f59e`](cockroachdb/pebble@3735f59e) db: change panic to fatalf for better debuggability
 * [`e494c554`](cockroachdb/pebble@e494c554) objstorage: move ReadableFile and SimpleReadable form sstable -> objstorage

Release note: none.
Epic: none.

Co-authored-by: Ricky Stewart <[email protected]>
Co-authored-by: Radu Berinde <[email protected]>
@craig
Copy link
Contributor

craig bot commented Dec 4, 2025

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Dec 4, 2025

@craig craig bot merged commit 8a383b1 into cockroachdb:master Dec 4, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants