-
Notifications
You must be signed in to change notification settings - Fork 4k
go.mod: bump Pebble to 36cb7a24d395 #158689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
craig
merged 1 commit into
cockroachdb:master
from
RaduBerinde:radu/pebble-master-36cb7a24d395
Dec 4, 2025
Merged
go.mod: bump Pebble to 36cb7a24d395 #158689
craig
merged 1 commit into
cockroachdb:master
from
RaduBerinde:radu/pebble-master-36cb7a24d395
Dec 4, 2025
+29
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dt
approved these changes
Dec 3, 2025
Changes: * [`36cb7a24`](cockroachdb/pebble@36cb7a24) valsep: do not embed sstable.Writer methods on SSTBlobWriter * [`3735f59e`](cockroachdb/pebble@3735f59e) db: change panic to fatalf for better debuggability * [`e494c554`](cockroachdb/pebble@e494c554) objstorage: move ReadableFile and SimpleReadable form sstable -> objstorage Release note: none. Epic: none.
73d0aa8 to
b4ca58e
Compare
Member
Author
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Dec 4, 2025
158623: team: delete duplicate `TEAMS.yaml` file r=rail a=rickystewart There's no reason for this to be checked into the repo twice; the copy in the repo root is sufficient. Release note: none Epic: none 158632: ci: ensure we correctly report owners for generated tests r=rail,srosenberg,herkolategan,williamchoe3 a=rickystewart To do so, generate code before any time where we would be filing issues to test owners. Closes: #107885 Release note: none Epic: CRDB-36213 158689: go.mod: bump Pebble to 36cb7a24d395 r=RaduBerinde a=RaduBerinde Changes: * [`36cb7a24`](cockroachdb/pebble@36cb7a24) valsep: do not embed sstable.Writer methods on SSTBlobWriter * [`3735f59e`](cockroachdb/pebble@3735f59e) db: change panic to fatalf for better debuggability * [`e494c554`](cockroachdb/pebble@e494c554) objstorage: move ReadableFile and SimpleReadable form sstable -> objstorage Release note: none. Epic: none. 158773: sql/schemachanger: deflake backup and restore tests r=fqazi a=fqazi Previously, the backup and restore tests could flake locally or on CI because we relied on the second granularity of finished_time. This was not sufficient because tests could execute fast enough so that the status of the latest schema change could be confused. To address this, this patch uses the max job ID to detect newer jobs. Fixes: #158772 Release note: None Co-authored-by: Ricky Stewart <[email protected]> Co-authored-by: Radu Berinde <[email protected]> Co-authored-by: Faizan Qazi <[email protected]>
Contributor
|
Build failed (retrying...): |
craig bot
pushed a commit
that referenced
this pull request
Dec 4, 2025
158632: ci: ensure we correctly report owners for generated tests r=rail,srosenberg,herkolategan,williamchoe3 a=rickystewart To do so, generate code before any time where we would be filing issues to test owners. Closes: #107885 Release note: none Epic: CRDB-36213 158689: go.mod: bump Pebble to 36cb7a24d395 r=RaduBerinde a=RaduBerinde Changes: * [`36cb7a24`](cockroachdb/pebble@36cb7a24) valsep: do not embed sstable.Writer methods on SSTBlobWriter * [`3735f59e`](cockroachdb/pebble@3735f59e) db: change panic to fatalf for better debuggability * [`e494c554`](cockroachdb/pebble@e494c554) objstorage: move ReadableFile and SimpleReadable form sstable -> objstorage Release note: none. Epic: none. Co-authored-by: Ricky Stewart <[email protected]> Co-authored-by: Radu Berinde <[email protected]>
Contributor
|
Build failed (retrying...): |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
36cb7a24valsep: do not embed sstable.Writer methods on SSTBlobWriter3735f59edb: change panic to fatalf for better debuggabilitye494c554objstorage: move ReadableFile and SimpleReadable form sstable -> objstorageRelease note: none.
Epic: none.