Skip to content

document CURSOR WITH HOLD #19590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

document CURSOR WITH HOLD #19590

wants to merge 2 commits into from

Conversation

taroface
Copy link
Contributor

@taroface taroface commented May 7, 2025

@taroface taroface requested review from dikshant and DrewKimball May 7, 2025 21:15
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2025

Files changed:

@netlify Netlify
Copy link

netlify bot commented May 7, 2025 •
edited
Loading

✅ Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 5b047e4
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/681d0056da27cc0008cbf68e

@netlify Netlify
Copy link

netlify bot commented May 7, 2025 •
edited
Loading

✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 5b047e4
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/681d0056e8296f00089f5fd6

@taroface
Copy link
Contributor Author

taroface commented May 7, 2025

@DrewKimball @dikshant I also want to update the CURSOR sql diagram in a separate cockroach PR so that it exposes WITH HOLD. Should WITHOUT HOLD also be exposed in the diagram?

@netlify Netlify
Copy link

netlify bot commented May 7, 2025 •
edited
Loading

✅ Netlify Preview

Name Link
🔨 Latest commit 5b047e4
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/681d00563adc06000869020f
😎 Deploy Preview https://deploy-preview-19590--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DrewKimball
Copy link

@DrewKimball @dikshant I also want to update the CURSOR sql diagram in a separate cockroach PR so that it exposes WITH HOLD. Should WITHOUT HOLD also be exposed in the diagram?

Yes, I think so.

DrewKimball
DrewKimball approved these changes May 8, 2025
View reviewed changes
Copy link

@DrewKimball DrewKimball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taroface taroface requested a review from florence-crl May 8, 2025 19:46
florence-crl
florence-crl reviewed May 8, 2025
View reviewed changes
Copy link
Contributor

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 point of confusion that may need clarification.

src/current/v25.2/cursors.md
~~~
</section>

Declare a cursor using `WITH HOLD` to keep it open after the `COMMIT`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the Implicit section, it is confusing to see "to keep it open after the COMMIT". In the implicit example, each statement is an implicit transaction and has its own implicit commit. There is no actual COMMIT command listed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florence-crl florence-crl florence-crl left review comments

@DrewKimball DrewKimball DrewKimball approved these changes

@dikshant dikshant Awaiting requested review from dikshant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taroface @DrewKimball @florence-crl