Skip to content

WAL failover log config needs auditable: false #19719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

rmloveland
Copy link
Contributor

Fixes DOC-13861

Copy link

github-actions bot commented Jun 5, 2025

Files changed:

Copy link

netlify bot commented Jun 5, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit f65733e
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/684c6006cecf4b0008dab1aa

Copy link

netlify bot commented Jun 5, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit f65733e
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/684c6006ccaac500083ab29d

@rmloveland
Copy link
Contributor Author

via the linked issue DOC-13861, if the user doesn't have auditable: false they get the following error:

+file group "sql-auth": File-based audit logging cannot coexist with buffering configuration. Disable either the buffering configuration ("buffering") or auditable log ("auditable") configuration.

Copy link

netlify bot commented Jun 5, 2025

Netlify Preview

Name Link
🔨 Latest commit f65733e
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/684c6006cb31e00008c1a46c
😎 Deploy Preview https://deploy-preview-19719--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lin-crl
Copy link

lin-crl commented Jun 11, 2025

@rmloveland

Just want to let you know the default logging have auditable on for the following three channels. In implementation, we needed to turn them off. Not sure how you'd like to handle it in the documentation for WAL.
Otherwise it LGTM

    security:
      channels: [PRIVILEGES, USER_ADMIN]
      auditable: true
    sql-audit:
      channels: [SENSITIVE_ACCESS]
      auditable: true
    sql-auth:
      channels: [SESSIONS]
      auditable: true

@jbowens
Copy link

jbowens commented Jun 11, 2025

Just want to let you know the default logging have auditable on for the following three channels. In implementation, we needed to turn them off. Not sure how you'd like to handle it in the documentation for WAL.
Otherwise it LGTM

Do we know why we suggest that default? It seems ill-advised. auditable:true is generally bad for resiliency to latency.

@rmloveland
Copy link
Contributor Author

Just want to let you know the default logging have auditable on for the following three channels. In implementation, we needed to turn them off.

ack!

Do we know why we suggest that default? It seems ill-advised. auditable:true is generally bad for resiliency to latency.

idk why - It was done in a 4 year old PR: #11818, specifically this commit by the engineer who I think was working on the logging at that time.

Not sure how you'd like to handle it in the documentation for WAL.

I'd rather not do the other changes to the default logging config in this PR

I filed a docs issue (DOC-13963) to investigate and remove the auditable: true so we can make sure it gets some additional vetting by whatever team is the logging owner now

@rmloveland rmloveland requested a review from taroface June 12, 2025 14:27
Fixes DOC-13861

NB. Ported changes to all supported versions v24.1+
@rmloveland rmloveland force-pushed the 20250605-DOC-13861-wal-failover-file-based-logging branch from 6d1a50e to f65733e Compare June 13, 2025 17:29
@rmloveland rmloveland enabled auto-merge (squash) June 13, 2025 17:29
@rmloveland rmloveland merged commit ca2519e into main Jun 13, 2025
7 checks passed
@rmloveland rmloveland deleted the 20250605-DOC-13861-wal-failover-file-based-logging branch June 13, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants