-
Notifications
You must be signed in to change notification settings - Fork 470
WAL failover log config needs auditable: false
#19719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WAL failover log config needs auditable: false
#19719
Conversation
Files changed:
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
via the linked issue DOC-13861, if the user doesn't have
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
Just want to let you know the default logging have auditable on for the following three channels. In implementation, we needed to turn them off. Not sure how you'd like to handle it in the documentation for WAL.
|
Do we know why we suggest that default? It seems ill-advised. |
ack!
idk why - It was done in a 4 year old PR: #11818, specifically this commit by the engineer who I think was working on the logging at that time.
I'd rather not do the other changes to the default logging config in this PR I filed a docs issue (DOC-13963) to investigate and remove the |
Fixes DOC-13861 NB. Ported changes to all supported versions v24.1+
6d1a50e
to
f65733e
Compare
Fixes DOC-13861