Skip to content

codegen: update RecvMsg for gRPC compatibility #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shubhamdhama
Copy link

It's already here in the implementation of the StreamServer implementations but not available through interface, so essentially it's hidden. In this change we update its parameters to become compatible with gRPC and added that definition in the interface.

It's already here in the implementation of the StreamServer implementations
but not available through interface, so essentially it's hidden. In this
change we update its parameters to become compatible with gRPC and added
that definition in the interface.
@shubhamdhama
Copy link
Author

Some more context here: RecvMsg is defined in the stream server implementations,
but it's not exposed through the generated public interface. This change adds that
method to the interface, and while I'm at it, I'm updating the argument to match
what gRPC uses. This should avoid hacks like this and make the code
simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant