feat: Support Python 3.14 free-threaded #1357
Open
+87
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgeh0
reviewed
Dec 2, 2025
rust/cocoindex/Cargo.toml
Outdated
| [features] | ||
| default = ["legacy-states-v0"] | ||
| legacy-states-v0 = [] | ||
| legacy-states-v0 = [ "pyo3/abi3-py311"] |
Member
There was a problem hiding this comment.
Let's enable this feature by default (just put it in pyo3 below). It doesn't belong to legacy-states-v0
Author
There was a problem hiding this comment.
abi3-py311 now lives in a new abi3 feature which is part of default.
| default = ["legacy-states-v0"] | ||
| legacy-states-v0 = [] | ||
| legacy-states-v0 = [ "pyo3/abi3-py311"] | ||
| free-threaded = [] |
Member
There was a problem hiding this comment.
Seems this one is not used anywhere.
Author
There was a problem hiding this comment.
This feature now controls whether #[pymodule] is declared with gil_used = false.
georgeh0
reviewed
Dec 3, 2025
Comment on lines
+606
to
+607
| #[cfg_attr(feature = "free-threaded", pymodule(gil_used = false))] | ||
| #[cfg_attr(not(feature = "free-threaded"), pymodule)] |
Member
There was a problem hiding this comment.
I think we don't need two branches here. We can always declare gil_used = false.
Based on the documentation, as long as our code is thread safe, we can use gil_used = false here. When it's declared false, both with-gil and thread-safe python can use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Python 3.14 free-threaded mode support to CocoIndex, resolving #1187
Key Changes: