-
Notifications
You must be signed in to change notification settings - Fork 131
feat: support union type for basic types #510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support union type for basic types #510
Conversation
I just added some test cases and fixed some bugs. There are some problems with |
I have updated the test cases, and it works now. Now I'm trying to figure out if this implementation works with databases (i.e., Qdrant, Postgres, Neo4j, and Kuzu). My concern right now is especially on Kuzu, because it has a native C-like union type, which functions very different from the others. |
That's a fair concern. I had similar concern, e.g. users need to access using tags like |
I just checked current implementation. I have removed union implementation for Kuzu. And it is JSON for Postgres and Qdrant, but I have introduced |
Yes, we should have For Postgres, we're using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also run ./check.sh
, which will run autoformat and will resolve github workflow check errors.
Thanks a lot for pushing through this feature, and all revisions along the way! |
Here is my solution on the union type support. It includes basic conversions and representations for the union type.
If there are any problems with the change, feel free to speak out for revision or reject.
Context
This PR is an attempt to solve Issue #436. It includes descriptions and conceptual works about union type support.