Skip to content

fix: out of range read when file size > BUFFER_SIZE #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cocool97 merged 1 commit into from
Feb 22, 2026
Merged

fix: out of range read when file size > BUFFER_SIZE #183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion adb_client/src/server_device/commands/recv.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ impl<R: Read> Read for ADBRecvCommandReader<R> {
match &header[..] {
b"DATA" => {
let length = self.inner.read_u32::<LittleEndian>()? as usize;
let effective_read = self.inner.read(&mut buf[0..length])?;
// ensuring read data is at most the buffer length
let min_data_to_read = std::cmp::min(length, buf.len());
let effective_read = self.inner.read(&mut buf[0..min_data_to_read])?;
self.remaining_data_bytes_to_read = length - effective_read;

Ok(effective_read)
Expand Down
Loading