chore: code review fixes 2026-05 (with breaking API tightenings) - #2

Merged

CMGS merged 20 commits into

mainfrom

chore-code-review-202605

May 13, 2026

Commits on May 13, 2026

fix(auth): enforce session expiry in VerifySession
CMGS
committed
0662629
fix(auth): panic on crypto/rand failure in RandomState
CMGS
committed
f97272e
fix(k8s): fall back to self-signed when on-disk cert expired
CMGS
committed
11b7499
feat(cocoonset): mark Agents/Toolboxes as listType=map
CMGS
committed
2353d97
refactor(meta): table-driven LifecycleState.IsTerminal
CMGS
committed
b055bdb
refactor(apis): table-driven enum IsValid + cmp.Or-based Default
CMGS
committed
d9156b8
refactor(meta): split meta.go by concern
CMGS
committed
c2e70e0
refactor(meta): drop unused LabelManagedBy
CMGS
committed
a11df46
fix(log)!: return error from Setup instead of Fatalf
CMGS
committed
59c391f
refactor(meta)!: return (string, bool) from OwnerDeploymentName
CMGS
committed
758b4ee
fix(k8s)!: DetectNodeIP returns (string, error)
CMGS
committed
2127a96
refactor(meta)!: rename HasCocoonToleration to HasCocoonTolerationKey
CMGS
committed
dcb11a9
feat(meta): add toolbox-safe agent-slot helpers
CMGS
committed
4c7f78a
style: drop "previous behavior" leaks from godoc
CMGS
committed
4a44490
style: tighten godocs across packages
CMGS
committed
6b51984
refactor!: thread ctx through LoadOrGenerateCert; tighten meta helpers
CMGS
committed
9134970
fix(meta): InferRoleFromAgentSlot returns RoleToolbox for slot<0
CMGS
committed
27035ab
fix(auth): reject session at Exp == now (JWT-style)
CMGS
committed
4714e5c
fix(k8s): surface partial TLS keypair misconfig as error
CMGS
committed
e451b5e
style: trim verbose comments added in prior fixes
CMGS
committed
d15dd3c

Navigation Menu

Uh oh!

chore: code review fixes 2026-05 (with breaking API tightenings) - #2

chore: code review fixes 2026-05 (with breaking API tightenings)#2
CMGS merged 20 commits into
mainfrom
chore-code-review-202605

Commits on May 13, 2026

fix(auth): enforce session expiry in VerifySession

fix(auth): panic on crypto/rand failure in RandomState

fix(k8s): fall back to self-signed when on-disk cert expired

feat(cocoonset): mark Agents/Toolboxes as listType=map

refactor(meta): table-driven LifecycleState.IsTerminal

refactor(apis): table-driven enum IsValid + cmp.Or-based Default

refactor(meta): split meta.go by concern

refactor(meta): drop unused LabelManagedBy

fix(log)!: return error from Setup instead of Fatalf

refactor(meta)!: return (string, bool) from OwnerDeploymentName

fix(k8s)!: DetectNodeIP returns (string, error)

refactor(meta)!: rename HasCocoonToleration to HasCocoonTolerationKey

feat(meta): add toolbox-safe agent-slot helpers

style: drop "previous behavior" leaks from godoc

style: tighten godocs across packages

refactor!: thread ctx through LoadOrGenerateCert; tighten meta helpers

fix(meta): InferRoleFromAgentSlot returns RoleToolbox for slot<0

fix(auth): reject session at Exp == now (JWT-style)

fix(k8s): surface partial TLS keypair misconfig as error

style: trim verbose comments added in prior fixes