Skip to content

facebook android getUserId bug fix #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v4-develop
Choose a base branch
from
Open

facebook android getUserId bug fix #144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 39 additions & 27 deletions plugins/facebook/proj.android/src/org/cocos2dx/plugin/UserFacebook.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public class UserFacebook implements InterfaceUser{
private static final List<String> allPublishPermissions = Arrays.asList(
"publish_actions", "ads_management", "create_event", "rsvp_event",
"manage_friendlists", "manage_notifications", "manage_pages");
private static String userIdStr = "";
private static GraphUser me = null;
protected static void LogE(String msg, Exception e) {
Log.e(LOG_TAG, msg, e);
e.printStackTrace();
Expand All @@ -78,7 +78,11 @@ protected static void LogD(String msg) {
}

public String getUserID(){
return userIdStr;
if (me == null) {
return "";
} else {
return me.getId();
}
}

public UserFacebook(Context context) {
Expand Down Expand Up @@ -365,46 +369,54 @@ public void logPurchase(JSONObject info)
}
}


private class SessionStatusCallback implements Session.StatusCallback {
@Override
public void call(Session session, SessionState state, Exception exception) {
onSessionStateChange(session, state, exception);
public void call(final Session session, final SessionState state, final Exception exception) {
if (session != null && session.isOpened()) {
// make request to the /me API
Request.newMeRequest(session, new Request.GraphUserCallback() {
@Override
public void onCompleted(GraphUser user,
Response response) {
me = user;

call2(session, state, exception);
}
}).executeAsync();
} else {
call2(session, state, exception);
}
}

public void call2(Session session, SessionState state, Exception exception) {
if(false == isLoggedIn){
if(SessionState.OPENED == state){
isLoggedIn = true;
UserWrapper.onActionResult(mAdapter, UserWrapper.ACTION_RET_LOGIN_SUCCEED, getSessionMessage(session));
if (me == null) {
session.closeAndClearTokenInformation();
UserWrapper.onActionResult(mAdapter, UserWrapper.ACTION_RET_LOGIN_FAILED, getErrorMessage(null, "cannot get myself"));
} else {
isLoggedIn = true;
UserWrapper.onActionResult(mAdapter, UserWrapper.ACTION_RET_LOGIN_SUCCEED, getSessionMessage(session));
}
}else if(SessionState.CLOSED_LOGIN_FAILED == state /*|| SessionState.CLOSED == state*/){
UserWrapper.onActionResult(mAdapter, UserWrapper.ACTION_RET_LOGIN_FAILED, getErrorMessage(exception, "login failed"));
UserWrapper.onActionResult(mAdapter, UserWrapper.ACTION_RET_LOGIN_FAILED, getErrorMessage(exception, "login failed"));
}

}
else{
if(SessionState.OPENED_TOKEN_UPDATED == state){
UserWrapper.onActionResult(mAdapter, UserWrapper.ACTION_RET_LOGIN_SUCCEED, getSessionMessage(session));
if (me == null) {
session.closeAndClearTokenInformation();
UserWrapper.onActionResult(mAdapter, UserWrapper.ACTION_RET_LOGIN_FAILED, getErrorMessage(null, "cannot get myself"));
} else {
UserWrapper.onActionResult(mAdapter, UserWrapper.ACTION_RET_LOGIN_SUCCEED, getSessionMessage(session));
}
}
else if(SessionState.CLOSED == state || SessionState.CLOSED_LOGIN_FAILED == state){
isLoggedIn = false;
isLoggedIn = false;
UserWrapper.onActionResult(mAdapter, UserWrapper.ACTION_RET_LOGIN_FAILED, getErrorMessage(exception, "failed"));
}
}
}
}

private void onSessionStateChange(Session session, SessionState state,
Exception exception) {
if (session != null && session.isOpened()) {
// make request to the /me API
Request.newMeRequest(session, new Request.GraphUserCallback() {
@Override
public void onCompleted(GraphUser user,
Response response) {
if (user != null) {
userIdStr = user.getId();
}

}
}).executeAsync();
}
}

Expand Down