Sprite::setScaleY: fix a potential crash on iOS#20680
Open
BodbDearg wants to merge 1 commit intococos2d:v4from
BodbDearg:bugfix/fix-sprite-setscaley-crash
Open
Sprite::setScaleY: fix a potential crash on iOS#20680BodbDearg wants to merge 1 commit intococos2d:v4from BodbDearg:bugfix/fix-sprite-setscaley-crash
BodbDearg wants to merge 1 commit intococos2d:v4from
BodbDearg:bugfix/fix-sprite-setscaley-crash
Conversation
…texture assigned. Need to add a null check for a bit of Metal specific code.
Contributor
Author
|
The CI failure doesn't look related in any way to the changes made. Not sure what is going on there? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crash occurs if the sprite has no texture assigned. Need to add a null check for a bit of Metal specific code.