Bump react-i18next from 15.4.0 to 17.0.10 in /js - #199
Conversation
Bumps [react-i18next](https://github.com/i18next/react-i18next) from 15.4.0 to 17.0.10. - [Changelog](https://github.com/i18next/react-i18next/blob/master/CHANGELOG.md) - [Commits](i18next/react-i18next@v15.4.0...v17.0.10) --- updated-dependencies: - dependency-name: react-i18next dependency-version: 17.0.10 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
The review identified critical security vulnerabilities and implementation gaps that prevent merging in its current state:
- Security Vulnerabilities: High-severity flaws were detected, including a Remote Code Execution (RCE) vulnerability in
simple-gitand Open Redirect vulnerabilities inreact-router-dom. - Missing Requirements: The update for
js/libs/ui-shared/package.jsonis missing from the PR, despite being a core requirement. - Unaddressed Breaking Changes: Moving from v15 to v17 introduces significant breaking changes, such as a new default for
useSuspenseand a requirement fori18nextcore version 26.0.1 or higher. The PR lacks the necessary logic updates and peer dependency bumps to support this major upgrade.
About this PR
- The changelog for react-i18next v17.0.1 indicates a requirement for i18next >= 26.0.1. The project's current i18next version was not updated in this PR, which may lead to runtime errors or peer dependency conflicts.
- The upgrade from react-i18next v15 to v17 involves breaking changes. Manual code adjustments, such as verifying component rendering or explicitly configuring suspense behavior, appear to be missing from this pull request.
2 comments outside of the diff
js/pnpm-lock.yaml
line 310🔴 HIGH RISK
A high-severity Remote Code Execution (RCE) vulnerability (CVE-2026-6951) was detected in simple-git. This vulnerability allows attackers to execute arbitrary shell commands via incomplete sanitization. It is highly recommended to update this dependency to version 3.36.0 or higher.
line 95🟡 MEDIUM RISK
i18next-http-backend contains a Path Traversal and URL Injection vulnerability (CVE-2026-41691). As you are currently updating the internationalization stack, please update this dependency to version 3.0.5 or higher.
Test suggestions
- Verify that the i18next core dependency is at version 26.0.1 or higher to satisfy the new peer dependency requirement introduced in v17.0.1.
- Confirm that the application handles the new default useSuspense: true behavior in useTranslation or has explicitly configured it to false to avoid unhandled suspension errors.
- Validate that the Trans component renders correctly when using nested HTML nodes, ensuring the fixes in v17.0.5 and v17.0.6 regarding nodesToString are verified.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that the i18next core dependency is at version 26.0.1 or higher to satisfy the new peer dependency requirement introduced in v17.0.1.
2. Confirm that the application handles the new default useSuspense: true behavior in useTranslation or has explicitly configured it to false to avoid unhandled suspension errors.
3. Validate that the Trans component renders correctly when using nested HTML nodes, ensuring the fixes in v17.0.5 and v17.0.6 regarding nodesToString are verified.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| "react-hook-form": "^7.54.2", | ||
| "react-i18next": "^15.4.0", | ||
| "react-i18next": "^17.0.10", | ||
| "react-router-dom": "^6.29.0", |
There was a problem hiding this comment.
🔴 HIGH RISK
Suggestion: The react-router-dom dependency uses a version of react-router containing an Open Redirect vulnerability (CVE-2026-40181). An attacker could redirect users to malicious sites via specially crafted URLs. Consider updating this dependency:
| "react-router-dom": "^6.29.0", | |
| "react-router-dom": "^6.30.4", |
| "react-hook-form": "^7.54.2", | ||
| "react-i18next": "^15.4.0", | ||
| "react-i18next": "^17.0.10", | ||
| "react-router-dom": "^6.29.0" |
There was a problem hiding this comment.
🔴 HIGH RISK
Suggestion: The react-router-dom dependency uses a version of react-router containing an Open Redirect vulnerability (CVE-2026-40181). An attacker could redirect users to malicious sites via specially crafted URLs. Consider updating this dependency:
| "react-router-dom": "^6.29.0" | |
| "react-router-dom": "^6.30.4" |
Bumps react-i18next from 15.4.0 to 17.0.10.
Changelog
Sourced from react-i18next's changelog.
... (truncated)
Commits
3b71c2717.0.1057c3500buildc62476fchore: sync package-lock with i18next ^26.2.0 devDependency bump0126bd1improve instance warnings (monorepo hint) + dev-only suspense warning + weekl...8b4a9ea17.0.9422bab1fix: support typescript 7 — widen peer range and fix Trans ns inference under...6e18aa9README: mention npx i18next-cli localize as the zero-to-localized patha46ad2317.0.8f715031update i18next depa515d5bchangelog: 17.0.8 entry for #1921You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)