[pull] main from expo:main #497
Merged
+16
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nder (#42153) # Why When `useReleaseSharedObject` creates a new object in its `useMemo` hook, it calls release on the old one immediately. This can cause a callsite to try to use the object (after the hook released the old object, but before the render function has finished) This is visible in `expo-audio` where the audio recorder is released and then used, causing an exception to be thrown on both iOS and Android complaining about a released object being accessed. # How This fixes the above problem by deferring releasing the object until after render is done. # Test Plan - Run BareExpo - Open `API` / `Audio` - Open Audio recorder screen - Toggle high/low quality Observe: The app crashes Expected: App should not crash ✅ Bare Expo iOS ✅ Bare Expo Android # Checklist - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Tomasz Sapeta <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )