[pull] main from expo:main #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Why This PR adds support for monograms on Apple Maps markers, as documented in Apple's MapKit API: https://developer.apple.com/documentation/mapkit/marker/init(_:monogram:coordinate:)-2ojcy Monograms allow displaying short text (typically initials like "JD" for "John Doe") directly on the marker balloon, which is useful for contact-style markers or location codes without requiring a custom SF Symbol. # How Added a new optional `monogram` property to `AppleMapsMarker`: - **TypeScript**: Added `monogram?: string` field to the `AppleMapsMarker` type - **Swift**: Added `monogram` field to `MapMarker` struct with a computed `hasMonogram` property - **iOS17/iOS18 Views**: Updated marker rendering to conditionally use the `Marker(_:monogram:coordinate:)` initializer when a monogram is provided and no `systemImage` is set The `systemImage` property takes precedence over `monogram` if both are provided, ensuring backward compatibility. # Test Plan 1. Create markers with the `monogram` property set to initials (e.g., "AB", "JD") 2. Verify the marker displays the monogram text on the balloon instead of a pin icon 3. Test that markers with `systemImage` still display the SF Symbol correctly 4. Test that markers with both `systemImage` and `monogram` use `systemImage` (precedence) 5. Test on both iOS 17+ and iOS 18+ devices to ensure both view implementations work
# Why There is swiftlint issue in our native ios code # How run `swiftlint lint --config [path-to-expo-repo]/.swiftlint.yml --strict [path-to-expo-repo]/packages/expo-router --fix` # Test Plan CI # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
# Why @tomekzaw reported an issue, that in his setup he gets an error: `'Logger' is ambiguous for type lookup`. The other type that was found is `os.Logger`. I couldn't reproduce the issue locally, but the approach used in this PR solves it, by specifying which `Logger` to use. # How Change `Logger` to `ExpoModulesCore.Logger` # Test Plan 1. Build the router-e2e app # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
…fig plugin (#42231) # Why Add a comment to make it clear, which library set this plugin to true # How <!-- How did you build this feature or fix this bug and why? --> # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
# Why The promises resolve after the test ends. A race condition caused `writeContactToFileAsync` to throw an exception - contacts were deleted before the function even started. # How Rewrite the test to use async/await properly and to run in isolation from other tests. # Test Plan Tested on bare-expo
…42203) # Why Fixes an issue with adding a contact when a default account is set to cloud: `Cannot add contacts to local or SIM accounts when default account is set to cloud` The problem seems to occur only on pure Android - I reproduced it on Google Pixel, while for example on Xiaomi it doesn't happen. The cause is adding a contact with the account type/name hardcoded to null, whereas those fields should be overwritten with the system default type. # How Removes unnecessary hardcoded ACCOUNT_TYPE and ACCOUNT_NAME when creating a contact. When they are not present, the system can create a contact in its default location. # Test Plan Tested on BareExpo on Google Pixel 9 and Xiaomi Poco X3 Pro
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )