[pull] main from expo:main #509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Why Initial implementation of Expo Widgets, will need a few follow ups and improvements before alpha. # How Updating widget snapshot serializes `@expo/ui` views tree to JSON and then recreates it in widget/live-activity using SwiftUI. # Test Plan Manual testing in #42094
# Why When using `withAnchor` to navigate to deeply nested routes (e.g., `/second/third/target`), the anchor route was only being loaded for the root level of the navigation stack. This meant that when navigating back from a deeply nested screen, users would not see the expected anchor screen at intermediate navigation levels. Fixes #40230 **Before** https://github.com/user-attachments/assets/ef97423e-3174-44bd-873a-776ea1387bf9 **After** https://github.com/user-attachments/assets/546563b4-e573-4bb7-8503-49a7f1602db7 # How The fix propagates the `initial` parameter through all nested `params` objects in the navigation payload, not just the root level. Previously, only `rootPayload.params.initial` was set, but nested navigators also need this flag to properly load their anchor routes. The change replaces: ```ts rootPayload.params.initial = !withAnchor; ``` With a loop that traverses all nested params: ```ts let currentParams = rootPayload.params; while (currentParams) { currentParams.initial = !withAnchor; currentParams = currentParams.params; } ``` Additionally, the condition `withAnchor !== undefined` was simplified to just `withAnchor` since the only meaningful case is when `withAnchor` is truthy. # Test Plan 1. Unit tests 2. Manual testing # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
# Why Actions that revolve around the symlink (e.g. `npm pack` or just directly running `yarn prepack`) end in an error wven though the file exists: ```bash > expo-brownfield@0.0.1 prepack > cp -L plugin/templates/ios/ExpoAppDelegate.swift plugin/templates/ios/ExpoAppDelegate.swift.tmp \ && mv plugin/templates/ios/ExpoAppDelegate.swift.tmp plugin/templates/ios/ExpoAppDelegate.swift cp: plugin/templates/ios/ExpoAppDelegate.swift: No such file or directory ``` That's because symlink seems to be an absolute path instead of a relative one: ```bash > ls -al plugin/templates/ios total 64 drwxr-xr-x 11 patrykmleczek staff 352 Jan 20 10:56 . drwxr-xr-x 5 patrykmleczek staff 160 Jan 20 10:30 .. lrwxr-xr-x 1 patrykmleczek staff 87 Jan 20 10:56 ExpoAppDelegate.swift -> /Users/gabriel/Workspace/expo/expo/packages/expo/ios/AppDelegates/ExpoAppDelegate.swift -rw-r--r-- 1 patrykmleczek staff 516 Jan 9 08:13 Info.plist ``` # How Changed symlink to be a relative path to the original `ExpoAppDelegate.swift` # Test Plan Tested using `npx expo prebuild` and `npx expo-brownfield build-ios` in `apps/minimal-tester` # Checklist - [X] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
# Why Interactive widgets are cool. # How Set the update function and invoke it in JSC when interaction is made.
# Why `expo-widgets` should not be available in Expo Go # How Exclude package from autolinking # Test Plan `pod install` in `expo-go`
Co-authored-by: Kadi Kraman <kadi@expo.io>
# Why `expo-router` was missing from modules in expo-go on Android # How <!-- How did you build this feature or fix this bug and why? --> # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )