Skip to content

implemented project level user pins - #1275

Open
raphael-goetz wants to merge 2 commits into
mainfrom
#557-project-pins
Open

implemented project level user pins#1275
raphael-goetz wants to merge 2 commits into
mainfrom
#557-project-pins

Conversation

@raphael-goetz

Copy link
Copy Markdown
Member

Resolves: #557

@raphael-goetz
raphael-goetz marked this pull request as ready for review September 9, 2026 11:48
@raphael-goetz raphael-goetz self-assigned this Sep 9, 2026
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2841077477

Status: Failed
Duration: 9 minutes

Job summaries

rspec: [cloud]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/16449108757/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2841077477/test_report
Finished in 49.77 seconds (files took 12.58 seconds to load)
1928 examples, 1 failure
Line Coverage: 93.61% (7022 / 7501)
[TEST PROF INFO] Time spent in factories: 00:27.725 (48.17% of total time)

rspec: [ee]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/16449108756/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2841077477/test_report
Finished in 29.82 seconds (files took 8.78 seconds to load)
1858 examples, 0 failures
Line Coverage: 93.75% (6824 / 7279)
[TEST PROF INFO] Time spent in factories: 00:16.122 (45.25% of total time)

rspec: [ce]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/16449108755/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2841077477/test_report
Finished in 47.98 seconds (files took 11.96 seconds to load)
1803 examples, 0 failures
Line Coverage: 93.39% (6617 / 7085)
[TEST PROF INFO] Time spent in factories: 00:26.613 (48.0% of total time)

docs:preview

Documentation preview available at https://code0-tech.gitlab.io/-/development/telescopium/-/jobs/16449222873/artifacts/out/index.html

rubocop

1071 files inspected, no offenses detected

@nicosammito nicosammito left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about the current implementation. remove the namespacePins and projectPins from the User Object. Add a pinned property to Namespace and NamespaceProject. It should be user depended. Make sure you also adjust the mutation for pinning NamespaceProjects because this is linked to a Namespace

@Taucher2003

Copy link
Copy Markdown
Member

remove the namespacePins and projectPins from the User Object. Add a pinned property to Namespace and NamespaceProject. It should be user depended.

I would disagree with that. If you think about the data graph, the pinned namespaces and projects belong to a user. The namespace or project doesn't care whether it is pinned or not.
Also, once you start to actually paginate in sculptor without automatically fetching all pages, the pins would break if the pinned namespaces or projects aren't on the first page of results for the user.

@nicosammito

Copy link
Copy Markdown
Member

remove the namespacePins and projectPins from the User Object. Add a pinned property to Namespace and NamespaceProject. It should be user depended.

I would disagree with that. If you think about the data graph, the pinned namespaces and projects belong to a user. The namespace or project doesn't care whether it is pinned or not. Also, once you start to actually paginate in sculptor without automatically fetching all pages, the pins would break if the pinned namespaces or projects aren't on the first page of results for the user.

Completely forgot about this. Okay then, the projectPins just need to be linked to a Namespace. So adjust the usersUpdateProjectPins mutation and the User.projectPins field

@nicosammito nicosammito left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to pin projects per organization and user

3 participants