-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add create commit to empty-upload
command
#654
Conversation
This is so that we can also create the commit before uploading. The create-commit is optional (i.e. if users don't pass in values, then their workflow shouldn't break). It will only create a commit if the values are passed.
cded5db
to
f9c8a47
Compare
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
❌ 5 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
codecov_cli/commands/empty_upload.py
Outdated
): | ||
with sentry_sdk.start_transaction(op="task", name="Empty Upload"): | ||
with sentry_sdk.start_span(name="empty_upload"): | ||
enterprise_url = ctx.obj.get("enterprise_url") | ||
args = get_cli_args(ctx) | ||
|
||
if parent_sha and pull_request_number and branch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this necessary to check for? I would assume that not every empty_upload would be on a PR for example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh true. I added these here to check if I should create a commit. I don't want to call create commit if the user is not intending to create a commit (i.e. old workflow). But these fields were all optional for the create-commit
command anyways, so maybe it's fine to remove the check. I'll check on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove the check. The create-commit logic seems to check that a commit exists before it adds, so it doesn't create duplicate updates.
05a0e33
to
0703f0f
Compare
This is because build is failing for 3.13
0703f0f
to
9acf3ae
Compare
9acf3ae
to
2e3d4c6
Compare
This is so that we can also create the commit before uploading. The create-commit is optional (i.e. if users don't pass in values, then their workflow shouldn't break). It will only create a commit if the values are passed.