Update CI and use nextest
#59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the CI definitions a bit: - Invokes `rustup` directly instead of using an action - Updates the `setup-python` action to the latest version - Adds a separate `doctest` run to run doctests and emit `cargo doc` errors - Switches to `nextest` for running test, which also has builtin junit output - Always run tests with coverage
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
- Coverage 98.53% 98.52% -0.02%
==========================================
Files 21 21
Lines 6775 6772 -3
==========================================
- Hits 6676 6672 -4
- Misses 99 100 +1
☔ View full report in Codecov by Sentry. |
| - uses: taiki-e/install-action@nextest | ||
|
|
||
| # FIXME(swatinem): We should pass `--all-targets` to also compile and tests benchmarks | ||
| # Though currently `divan` does not support all CLI arguments as used by `nextest`, |
There was a problem hiding this comment.
you moved us off divan in another PR, is this still relevant?
There was a problem hiding this comment.
You are right, I forgot to fix that in the followup PR, will do :-)
There was a problem hiding this comment.
Well actually, running the benchmark in test mode runs one iteration of the benchmark. Which won’t complete in any reasonable time in debug builds. So until I make progress on speeding that up, this won’t be feasible until then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the CI definitions a bit:
rustupdirectly instead of using an actionsetup-pythonaction to the latest versiondoctestrun to run doctests and emitcargo docerrorsnextestfor running test, which also has builtin junit output