adding new helm chart #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trent-codecov
requested changes
Oct 18, 2024
| @@ -0,0 +1,22 @@ | |||
| 1. Get the application URL by running these commands: | |||
There was a problem hiding this comment.
You don't need this file imo
| @@ -0,0 +1,43 @@ | |||
| {{- if .Values.ingress.enabled -}} | |||
There was a problem hiding this comment.
This isn't horrible to add but we will never use in favor of emissary
| @@ -0,0 +1,15 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
Remove this file unless you are going to make ci for it
|
|
||
| # This sets the container image more information can be found here: https://kubernetes.io/docs/concepts/containers/images/ | ||
| image: | ||
| repository: nginx |
| port: 80 | ||
|
|
||
| # This block is for setting up the ingress for more information can be found here: https://kubernetes.io/docs/concepts/services-networking/ingress/ | ||
| ingress: |
There was a problem hiding this comment.
Remove. Assuming you remove the ingress file
| # memory: 128Mi | ||
|
|
||
| # This is to setup the liveness and readiness probes more information can be found here: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/ | ||
| livenessProbe: |
There was a problem hiding this comment.
Update this to health or whatever we use in the old yaml
| name: codecov_slack_app | ||
| description: A Helm chart for Kubernetes | ||
|
|
||
| # A chart can be either an 'application' or a 'library' chart. |
There was a problem hiding this comment.
Remove these comments for brevity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
adding helm chart
Changes
Checklist
Additional Notes