Skip to content

[Kafka] CC-1645: Upgrade Rust to 1.85 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025
Merged

[Kafka] CC-1645: Upgrade Rust to 1.85 #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions compiled_starters/rust/.codecrafters/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,6 @@
#
# Learn more: https://codecrafters.io/program-interface

set -e # Exit on failure

exec /tmp/codecrafters-build-kafka-rust/release/codecrafters-kafka "$@"
2 changes: 1 addition & 1 deletion compiled_starters/rust/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ That's all!

Note: This section is for stages 2 and beyond.

1. Ensure you have `cargo (1.82)` installed locally
1. Ensure you have `cargo (1.85)` installed locally
1. Run `./your_program.sh` to run your Kafka broker, which is implemented in
`src/main.rs`. This command compiles your Rust project, so it might be slow
the first time you run it. Subsequent runs will be fast.
Expand Down
4 changes: 2 additions & 2 deletions compiled_starters/rust/codecrafters.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ debug: false
# Use this to change the Rust version used to run your code
# on Codecrafters.
#
# Available versions: rust-1.82
language_pack: rust-1.82
# Available versions: rust-1.85
language_pack: rust-1.85
13 changes: 13 additions & 0 deletions dockerfiles/rust-1.85.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# syntax=docker/dockerfile:1.7-labs
FROM rust:1.85-bookworm

# Rebuild the container if these files change
ENV CODECRAFTERS_DEPENDENCY_FILE_PATHS="Cargo.toml,Cargo.lock"

WORKDIR /app

# .git & README.md are unique per-repository. We ignore them on first copy to prevent cache misses
COPY --exclude=.git --exclude=README.md . /app
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix invalid COPY flag usage.
The Dockerfile uses --exclude with the COPY command, which is not supported. To exclude .git and README.md, consider using a .dockerignore file.

🧰 Tools
🪛 Hadolint (2.12.0)

[error] 10-10: invalid flag: --exclude

(DL1000)


# This runs cargo build
RUN .codecrafters/compile.sh
2 changes: 2 additions & 0 deletions solutions/rust/01-vi6/code/.codecrafters/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,6 @@
#
# Learn more: https://codecrafters.io/program-interface

set -e # Exit on failure

exec /tmp/codecrafters-build-kafka-rust/release/codecrafters-kafka "$@"
2 changes: 1 addition & 1 deletion solutions/rust/01-vi6/code/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ That's all!

Note: This section is for stages 2 and beyond.

1. Ensure you have `cargo (1.82)` installed locally
1. Ensure you have `cargo (1.85)` installed locally
1. Run `./your_program.sh` to run your Kafka broker, which is implemented in
`src/main.rs`. This command compiles your Rust project, so it might be slow
the first time you run it. Subsequent runs will be fast.
Expand Down
4 changes: 2 additions & 2 deletions solutions/rust/01-vi6/code/codecrafters.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ debug: false
# Use this to change the Rust version used to run your code
# on Codecrafters.
#
# Available versions: rust-1.82
language_pack: rust-1.82
# Available versions: rust-1.85
language_pack: rust-1.85
2 changes: 2 additions & 0 deletions starter_templates/rust/code/.codecrafters/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,6 @@
#
# Learn more: https://codecrafters.io/program-interface

set -e # Exit on failure

exec /tmp/codecrafters-build-kafka-rust/release/codecrafters-kafka "$@"
2 changes: 1 addition & 1 deletion starter_templates/rust/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
attributes:
required_executable: cargo (1.82)
required_executable: cargo (1.85)
user_editable_file: src/main.rs
Loading