[SQLite] [CC-1642] Upgrade Gleam to 1.9 #126
Conversation
WalkthroughThe pull request updates the Gleam programming language version requirements across various starter and configuration files. Both README files and configuration files now specify a fixed minimum version (1.9.1 or gleam-1.9) instead of a range. In addition, a new Dockerfile for Gleam 1.9.1 has been introduced with defined build steps and caching mechanisms. Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant Docker as Docker Daemon
participant Base as Base Image (gleam:v1.9.1)
participant Build as Build Process
Dev->>Docker: Run "docker build"
Docker->>Base: Pull base image "ghcr.io/gleam-lang/gleam:v1.9.1-erlang-alpine"
Docker->>Build: Set working directory (/app) and define environment variables
Docker->>Build: Copy project files (exclude .git and README.md)
Docker->>Build: Execute "gleam build" for dependency management
Docker->>Build: Create cache directory (/app-cached) and move build artifacts
Docker->>Dev: Complete build process
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
compiled_starters/gleam/README.md(1 hunks)compiled_starters/gleam/codecrafters.yml(1 hunks)dockerfiles/gleam-1.9.Dockerfile(1 hunks)solutions/gleam/01-dr6/code/README.md(1 hunks)solutions/gleam/01-dr6/code/codecrafters.yml(1 hunks)starter_templates/gleam/config.yml(1 hunks)
🧰 Additional context used
🪛 Hadolint (2.12.0)
dockerfiles/gleam-1.9.Dockerfile
[error] 10-10: invalid flag: --exclude
(DL1000)
⏰ Context from checks skipped due to timeout of 90000ms (11)
- GitHub Check: test_course_definition / test (zig)
- GitHub Check: test_course_definition / test (typescript)
- GitHub Check: test_course_definition / test (swift)
- GitHub Check: test_course_definition / test (rust)
- GitHub Check: test_course_definition / test (kotlin)
- GitHub Check: test_course_definition / test (java)
- GitHub Check: test_course_definition / test (go)
- GitHub Check: test_course_definition / test (gleam)
- GitHub Check: test_course_definition / test (csharp)
- GitHub Check: test_course_definition / test (cpp)
- GitHub Check: test_course_definition / test (c)
🔇 Additional comments (8)
starter_templates/gleam/config.yml (1)
2-2: Fixed Version Requirement Update:
Therequired_executableattribute has been updated from a version range (implied by the previous"1.0+") to a fixed version"gleam (1.9.1)". This ensures that all users are mandated to use the specified Gleam version for consistency.solutions/gleam/01-dr6/code/codecrafters.yml (1)
10-11: Language Pack Version Update:
The configuration now specifieslanguage_pack: gleam-1.9with an updated comment indicating the available version. This change aligns the configuration with the fixed minimum version requirement and promotes consistency across the project files.compiled_starters/gleam/README.md (1)
32-32: Installation Instruction Update:
The installation instructions have been updated to requiregleam (1.9.1), ensuring that users install the correct and expected version. This documentation update is consistent with the configuration changes in other parts of the project.solutions/gleam/01-dr6/code/README.md (1)
32-32: Version Requirement Clarity:
The README now states clearly that users need to havegleam (1.9.1)installed locally. This update removes ambiguity around the Gleam version requirement and aligns with the changes on other fronts.compiled_starters/gleam/codecrafters.yml (1)
10-11: Language Pack Configuration Consistency:
Thelanguage_packfield has been updated togleam-1.9along with the corresponding comment reflecting the available version. This change brings consistency with the other Gleam-related configuration files in the repository.dockerfiles/gleam-1.9.Dockerfile (3)
1-2: Update Dockerfile syntax and base image
The Dockerfile correctly sets the required Docker syntax and uses the Gleam 1.9.1 base image, ensuring the build environment meets the new version specification.
4-7: Define Dependency File Paths and Working Directory
The environment variableCODECRAFTERS_DEPENDENCY_FILE_PATHSis properly defined to trigger rebuilds whengleam.tomlormanifest.tomlchange, and the working directory/appis appropriately set.
12-17: Cache and Build Dependencies
The use ofRUN gleam buildto force dependency download and the subsequent commands to cache the build output (creating/app-cachedand moving the build directory) are well implemented to optimize subsequent builds.
| # .git & README.md are unique per-repository. We ignore them on first copy to prevent cache misses | ||
| COPY --exclude=.git --exclude=README.md . /app |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Fix COPY Command Invalid Flag Usage
The COPY command uses unsupported flags (--exclude), which is flagged by static analysis. Docker does not support --exclude on the COPY instruction. Instead, use a .dockerignore file to exclude .git and README.md. For example:
-COPY --exclude=.git --exclude=README.md . /app
+COPY . /appThen, create a .dockerignore file (if not already present) at the repository root with the following entries:
.git
README.md
This approach will prevent the specified files from being copied into the image and avoid cache misses.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # .git & README.md are unique per-repository. We ignore them on first copy to prevent cache misses | |
| COPY --exclude=.git --exclude=README.md . /app | |
| # .git & README.md are unique per-repository. We ignore them on first copy to prevent cache misses | |
| COPY . /app |
🧰 Tools
🪛 Hadolint (2.12.0)
[error] 10-10: invalid flag: --exclude
(DL1000)
Summary by CodeRabbit
Documentation
New Features
Chores