Skip to content

[SQLite] CC-1745: Upgrade Bun to v1.2, Rust to v1.86 #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2025
Merged

[SQLite] CC-1745: Upgrade Bun to v1.2, Rust to v1.86 #135

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a0c38d
Upgrade Rust and TypeScript versions to 1.86 and 1.2 respectively in …
andy1li May 15, 2025
91f81e6
Update Rust version to 1.86 in documentation and configuration files …
andy1li May 15, 2025
233e4ca
Update Rust version to 1.86 in codecrafters.yml files for starter tem…
andy1li May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiled_starters/rust/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Time to move on to the next stage!

Note: This section is for stages 2 and beyond.

1. Ensure you have `cargo (1.85)` installed locally
1. Ensure you have `cargo (1.87)` installed locally
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Verify Dockerfile for Rust 1.87 exists
Ensure that dockerfiles/rust-1.87.Dockerfile is committed and referenced by any CI or build pipelines.

Run:

🏁 Script executed:

#!/bin/bash
# Confirm presence of the Rust 1.87 Dockerfile
fd dockerfiles/rust-1.87.Dockerfile

Length of output: 37

🏁 Script executed:

#!/bin/bash
# List all Dockerfiles in the repository to locate any Rust-specific ones
find . -type f -name "*Dockerfile"

Length of output: 1728

🏁 Script executed:

#!/bin/bash
# Search for references to rust-1.87 Dockerfile in CI and workflow configurations
rg -n "rust-1\.87" --glob "*.yml" --glob "*.yaml" .github/ .gitlab-ci.yml azure-pipelines.yml ci/

Length of output: 258

Ensure CI workflows include the new Rust 1.87 Dockerfile
We’ve confirmed that dockerfiles/rust-1.87.Dockerfile is present, but no references to it were found in any CI or GitHub Actions workflow files. Please update your pipeline configurations to build/test with the Rust 1.87 image.

• File location: dockerfiles/rust-1.87.Dockerfile
• No matches in .github/ workflows or other CI configs
• Action: Add or update your CI manifests (e.g. .github/workflows/*.yml) to reference this new Dockerfile so Rust 1.87 is properly built and tested.

🤖 Prompt for AI Agents 
In compiled_starters/rust/README.md at line 32, the documentation mentions Rust
1.87 but there is no corresponding update in the CI or GitHub Actions workflows
to use the new dockerfiles/rust-1.87.Dockerfile. To fix this, locate your CI
pipeline configuration files (e.g., in .github/workflows/) and add or update the
workflow steps to reference and build/test using the rust-1.87 Dockerfile,
ensuring Rust 1.87 is properly integrated into your build and test processes.

1. Run `./your_program.sh` to run your program, which is implemented in
`src/main.rs`. This command compiles your Rust project, so it might be slow
the first time you run it. Subsequent runs will be fast.
Expand Down
4 changes: 2 additions & 2 deletions compiled_starters/rust/codecrafters.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ debug: false
# Use this to change the Rust version used to run your code
# on Codecrafters.
#
# Available versions: rust-1.85
language_pack: rust-1.85
# Available versions: rust-1.87
language_pack: rust-1.87
2 changes: 1 addition & 1 deletion compiled_starters/typescript/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Time to move on to the next stage!

Note: This section is for stages 2 and beyond.

1. Ensure you have `bun (1.1)` installed locally
1. Ensure you have `bun (1.2)` installed locally
1. Run `./your_program.sh` to run your program, which is implemented in
`app/main.ts`.
1. Commit your changes and run `git push origin master` to submit your solution
Expand Down
4 changes: 2 additions & 2 deletions compiled_starters/typescript/codecrafters.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ debug: false
# Use this to change the TypeScript version used to run your code
# on Codecrafters.
#
# Available versions: bun-1.1
language_pack: bun-1.1
# Available versions: bun-1.2
language_pack: bun-1.2
18 changes: 18 additions & 0 deletions dockerfiles/bun-1.2.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# syntax=docker/dockerfile:1.7-labs
FROM oven/bun:1.2-alpine

ENV CODECRAFTERS_DEPENDENCY_FILE_PATHS="package.json,bun.lockb"

WORKDIR /app

# .git & README.md are unique per-repository. We ignore them on first copy to prevent cache misses
COPY --exclude=.git --exclude=README.md . /app
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

⚠️ Potential issue

Invalid COPY flag: --exclude will break the build.
Docker’s COPY doesn’t support --exclude; this will error out (Hadolint DL1000). Use a .dockerignore to exclude files instead of flags.

Apply this diff:

-COPY --exclude=.git --exclude=README.md . /app
+COPY . /app

And ensure your project root contains a .dockerignore with:

.git
README.md
🧰 Tools
🪛 Hadolint (2.12.0)

[error] 9-9: invalid flag: --exclude

(DL1000)

🤖 Prompt for AI Agents 
In dockerfiles/bun-1.2.Dockerfile at line 9, the COPY command uses the
unsupported --exclude flag, which causes build errors. Remove the --exclude
flags from the COPY command so it simply copies all files from the current
directory to /app. Then, create a .dockerignore file in the project root listing
.git and README.md to exclude these files from the build context.


# For reproducible builds.
# This will install the exact versions of each package specified in the lockfile.
# If package.json disagrees with bun.lockb, Bun will exit with an error. The lockfile will not be updated.
RUN bun install --frozen-lockfile

# If the node_modules directory exists, move it to /app-cached
RUN mkdir -p /app-cached
RUN if [ -d "/app/node_modules" ]; then mv /app/node_modules /app-cached; fi
13 changes: 13 additions & 0 deletions dockerfiles/rust-1.86.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# syntax=docker/dockerfile:1.7-labs
FROM rust:1.86-bookworm

# Rebuild the container if these files change
ENV CODECRAFTERS_DEPENDENCY_FILE_PATHS="Cargo.toml,Cargo.lock"

WORKDIR /app

# .git & README.md are unique per-repository. We ignore them on first copy to prevent cache misses
COPY --exclude=.git --exclude=README.md . /app
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Invalid --exclude flag in COPY instruction
Docker’s COPY does not support --exclude—even with BuildKit labs enabled—so this will break your build. Remove the --exclude flags and use a .dockerignore file instead.

Apply this diff:

-COPY --exclude=.git --exclude=README.md . /app
+COPY . /app

And ensure your .dockerignore includes:

.git
README.md
🧰 Tools
🪛 Hadolint (2.12.0)

[error] 10-10: invalid flag: --exclude

(DL1000)

🤖 Prompt for AI Agents 
In dockerfiles/rust-1.86.Dockerfile at line 10, the COPY instruction incorrectly
uses the unsupported --exclude flag, which causes the build to fail. Remove the
--exclude flags from the COPY command so it simply copies the current directory
to /app. Then create or update the .dockerignore file in the build context root
to include .git and README.md, ensuring these files are excluded from the build
context instead of using --exclude in COPY.


# This runs cargo build
RUN .codecrafters/compile.sh
13 changes: 13 additions & 0 deletions dockerfiles/rust-1.87.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# syntax=docker/dockerfile:1.7-labs
FROM rust:1.87-bookworm

# Rebuild the container if these files change
ENV CODECRAFTERS_DEPENDENCY_FILE_PATHS="Cargo.toml,Cargo.lock"

WORKDIR /app

# .git & README.md are unique per-repository. We ignore them on first copy to prevent cache misses
COPY --exclude=.git --exclude=README.md . /app
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Invalid --exclude flag in COPY instruction
As above, Docker’s COPY doesn’t support --exclude. Replace with a simple COPY . /app and manage exclusions via .dockerignore.

-COPY --exclude=.git --exclude=README.md . /app
+COPY . /app

Ensure .dockerignore has:

.git
README.md
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
COPY --exclude=.git --exclude=README.md . /app
COPY . /app
🧰 Tools
🪛 Hadolint (2.12.0)

[error] 10-10: invalid flag: --exclude

(DL1000)

🤖 Prompt for AI Agents 
In dockerfiles/rust-1.87.Dockerfile at line 10, the COPY instruction incorrectly
uses the unsupported --exclude flag. Replace the COPY line with a simple COPY .
/app and add the excluded files and directories (.git and README.md) to a
.dockerignore file in the build context to prevent them from being copied.


# This runs cargo build
RUN .codecrafters/compile.sh
2 changes: 1 addition & 1 deletion solutions/rust/01-dr6/code/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Time to move on to the next stage!

Note: This section is for stages 2 and beyond.

1. Ensure you have `cargo (1.85)` installed locally
1. Ensure you have `cargo (1.87)` installed locally
1. Run `./your_program.sh` to run your program, which is implemented in
`src/main.rs`. This command compiles your Rust project, so it might be slow
the first time you run it. Subsequent runs will be fast.
Expand Down
4 changes: 2 additions & 2 deletions solutions/rust/01-dr6/code/codecrafters.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ debug: false
# Use this to change the Rust version used to run your code
# on Codecrafters.
#
# Available versions: rust-1.85
language_pack: rust-1.85
# Available versions: rust-1.87
language_pack: rust-1.87
2 changes: 1 addition & 1 deletion solutions/typescript/01-dr6/code/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Time to move on to the next stage!

Note: This section is for stages 2 and beyond.

1. Ensure you have `bun (1.1)` installed locally
1. Ensure you have `bun (1.2)` installed locally
1. Run `./your_program.sh` to run your program, which is implemented in
`app/main.ts`.
1. Commit your changes and run `git push origin master` to submit your solution
Expand Down
4 changes: 2 additions & 2 deletions solutions/typescript/01-dr6/code/codecrafters.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ debug: false
# Use this to change the TypeScript version used to run your code
# on Codecrafters.
#
# Available versions: bun-1.1
language_pack: bun-1.1
# Available versions: bun-1.2
language_pack: bun-1.2
2 changes: 1 addition & 1 deletion starter_templates/rust/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
attributes:
required_executable: cargo (1.85)
required_executable: cargo (1.87)
user_editable_file: src/main.rs
2 changes: 1 addition & 1 deletion starter_templates/typescript/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
attributes:
required_executable: bun (1.1)
required_executable: bun (1.2)
user_editable_file: app/main.ts
Loading