Skip to content

⚡️ Speed up method _FilterToGRPC.convert by 42% #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method _FilterToGRPC.convert by 42% #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions weaviate/collections/filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import uuid as uuid_lib
from typing import Any, Dict, List, Literal, Optional, cast, overload
from typing import Any, Dict, List, Literal, Optional, cast

from weaviate.collections.classes.filters import (
FilterValues,
Expand All @@ -21,19 +21,29 @@


class _FilterToGRPC:
@overload
@staticmethod
def convert(weav_filter: Literal[None]) -> None: ...
def convert(weav_filter: Literal[None]) -> None:
if weav_filter is None:
return None
elif type(weav_filter) is _FilterValue:
return _FilterToGRPC.__value_filter(weav_filter)
else:
return _FilterToGRPC.__and_or_not_filter(weav_filter)

@overload
@staticmethod
def convert(weav_filter: _Filters) -> base_pb2.Filters: ...
def convert(weav_filter: _Filters) -> base_pb2.Filters:
if weav_filter is None:
return None
elif type(weav_filter) is _FilterValue:
return _FilterToGRPC.__value_filter(weav_filter)
else:
return _FilterToGRPC.__and_or_not_filter(weav_filter)

@staticmethod
def convert(weav_filter: Optional[_Filters]) -> Optional[base_pb2.Filters]:
if weav_filter is None:
return None
elif isinstance(weav_filter, _FilterValue):
elif type(weav_filter) is _FilterValue:
return _FilterToGRPC.__value_filter(weav_filter)
else:
return _FilterToGRPC.__and_or_not_filter(weav_filter)
Expand Down