Skip to content

⚡️ Speed up method PhoneNumber._to_dict by 8% #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method PhoneNumber._to_dict by 8% #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions weaviate/collections/classes/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ class PhoneNumber(_PhoneNumberBase):
default_country: Optional[str] = Field(default=None)

def _to_dict(self) -> Mapping[str, str]:
out: Dict[str, str] = {"input": self.number}
if self.default_country is not None:
out["defaultCountry"] = self.default_country
return out
default_country = self.default_country
if default_country is None:
return {"input": self.number}
return {"input": self.number, "defaultCountry": default_country}


class _PhoneNumber(_PhoneNumberBase):
Expand Down