feat: Added entrypoint for tools to perform initialization. #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesiarmes
force-pushed
the
tools-entrypoint
branch
from
fbbf772 to
5a0279d
Compare
There was a problem hiding this comment.
Pull Request Overview
Adds Docker entrypoint functionality to enable initialization scripts for tools, allowing automated database setup and data source configuration when containers start.
- Implements modular entrypoint system that executes initialization scripts from
/entrypoint.d/ - Adds database initialization and data source creation capabilities
- Updates Docker configuration to use standard PostgreSQL image with proper environment variables
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docker/entrypoint.sh | Main entrypoint script that executes initialization scripts and passes through commands |
| docker/entrypoint.d/datasource-init.sh | Creates Senzing data sources based on SENZING_DATASOURCES environment variable |
| docker/entrypoint.d/database-init.sh | Initializes PostgreSQL database with Senzing schema if not already present |
| docker-compose.yaml | Updates to use standard postgres image and adds PostgreSQL connection environment variables |
| Dockerfile.tools | Installs PostgreSQL client, copies entrypoint scripts, and sets up proper entrypoint |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the changes to the Bitnami catalog, which prevents us from pinning the database container to a version, this also swaps out the database container for the official PostgreSQL one.