Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GYR] Reorder life situations checkboxes and remove must select one logic #5595

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[GYR] Reorder life situations checkboxes and remove must select one logic #5595

wants to merge 1 commit into from

Conversation

embarnard
Copy link
Contributor

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • reordered checkboxes on GYR's life situation page and remove logic to makes them select an option on that page

How to test?

  • use heroku, go to the life situations page in the flow or through the flow explorer

Screenshots (for visual changes)

  • After
Screenshot 2025-02-14 at 7 21 10 PM

@github-actions GitHub Actions
Copy link

Heroku app: https://gyr-review-app-5595-a8a0da5d26b9.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5595 (optionally add --tail)

arinchoi03
arinchoi03 approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@arinchoi03 arinchoi03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arinchoi03 arinchoi03 arinchoi03 approved these changes

Assignees
No one assigned
Labels
in-acceptance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@embarnard @arinchoi03