Declare the spotless version locally - #230
Merged
Merged
Conversation
The plugin version came from the parent's spotless-maven-plugin.version.
plexus-pom 27 renames every managed version to version.<artifactId>, so
that property disappears and the build fails at POM read with
'build.plugins.plugin.version' for com.diffplug.spotless:spotless-maven-plugin
must be a valid version but is '${spotless-maven-plugin.version}'
Declaring 3.9.0 here - the value the parent supplies today - keeps the
build working on both 26 and 27, so the parent bump stays a one-line
change. The name follows the parent's new convention, so once 27 is in
place this property can simply be deleted and inherited again.
slachiewicz
marked this pull request as ready for review
August 18, 2026 10:27
slachiewicz
added a commit
that referenced
this pull request
Aug 19, 2026
The spotless version declared locally in #230 goes with it: 27 supplies version.spotless-maven-plugin and manages the plugin, so both the property and the explicit <version> are redundant now. The plugin block keeps its configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spotless plugin version is inherited as
${spotless-maven-plugin.version}. plexus-pom 27 renames every managed version toversion.<artifactId>, so that property stops existing and this build fails at POM read:Declaring 3.9.0 here — the value the parent supplies today — keeps the build working under both 26 and 27, so the eventual parent bump is a one-line change instead of a two-part one that cannot be merged before the parent is released. The property name follows 27's convention, so it can be deleted and re-inherited afterwards.
Verified:
mvn clean verifygreen on parent 26 with spotless still resolving 3.9.0 and no source reformatted;mvn validategreen against a locally installed plexus-pom 27-SNAPSHOT.This change was created with AI assistance.