fix: preserve JSON body when CSRF token is sent in header#10064
Open
michalsn wants to merge 3 commits intocodeigniter4:developfrom
Open
fix: preserve JSON body when CSRF token is sent in header#10064michalsn wants to merge 3 commits intocodeigniter4:developfrom
michalsn wants to merge 3 commits intocodeigniter4:developfrom
Conversation
michalsn
added
the
bug
paulbalandan
approved these changes
Mar 23, 2026
Member
paulbalandan
left a comment
paulbalandan
left a comment
There was a problem hiding this comment.
Thanks! I'll release a patch tomorrow at the earliest.
samsonasik
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a regression in CSRF verification introduced in #9969.
When the CSRF token was sent via the
X-CSRF-TOKENheader, the CSRF filter could still parse the raw request body as form data and rewrite valid JSON into a URL-encoded string. As a result,IncomingRequest::getJSON()failed forapplication/jsonrequests.I am not sure whether this should be patched in 4.7.1 or included in 4.7.2.
Fixes #10063
Checklist: