Skip to content

refactor: fix phpstan errors in URI and SiteURI #9525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2025
Merged

refactor: fix phpstan errors in URI and SiteURI #9525

merged 1 commit into from
Apr 18, 2025

Conversation

paulbalandan
Copy link
Member

Description
Fixes a few errors in URI class.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Apr 14, 2025
@paulbalandan paulbalandan force-pushed the refactor-uri branch 2 times, most recently from 29fb2a4 to 34deca9 Compare April 14, 2025 14:45
@paulbalandan paulbalandan marked this pull request as draft April 14, 2025 15:09
@github-actions github-actions bot added the stale Pull requests with conflicts label Apr 16, 2025
@paulbalandan paulbalandan removed the stale Pull requests with conflicts label Apr 17, 2025
@codeigniter4 codeigniter4 deleted a comment from github-actions bot Apr 17, 2025
@paulbalandan paulbalandan marked this pull request as ready for review April 17, 2025 15:02
@paulbalandan paulbalandan merged commit fa0913c into codeigniter4:develop Apr 18, 2025
49 checks passed
@paulbalandan paulbalandan deleted the refactor-uri branch April 18, 2025 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbalandan @michalsn