Skip to content

discuss page contents space fix #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenjis merged 2 commits into from
Jun 8, 2024
Merged

discuss page contents space fix #450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
021aec4
discuss page contents space fix
May 26, 2024
ea63fb0
fix: line-height
kenjis Jun 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 9 additions & 14 deletions app/Views/discuss.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<div class="inner-page-text-box">
<div class="inner-page-text-box-title">Forum</div>
<p>
Our forum has been setup using MyBB, with five main categories: <br />
Our forum has been setup using MyBB (MyBulletinBoard), with five main categories:
</p>
<ul>
<li>General (news & discussion, lounge, events, and regional user groups)</li>
Expand All @@ -39,11 +39,10 @@
<li>External Resources (addins, jobs, learn more, and spotlight)</li>
</ul>
<p>
The forum is where you can ask for help or discuss issues you are having with framework.<br />
<a href="https://forum.codeigniter.com" class="buttons" target="_blank">Visit The Forum</a>
The forum is where you can ask for help or discuss issues you are having with framework.
</p>
<br /><br />
</div><!--inner-page-text-box ende-->
<a href="https://forum.codeigniter.com" class="buttons cta-btn" target="_blank">Visit The Forum</a>
</div><!--inner-page-text-box ends here-->

<div class="clr"></div>

Expand All @@ -56,10 +55,7 @@
class="link-primary" target="_blank">signup</a> for it :)
</p>

<p>
<a href="https://join.slack.com/t/codeigniterchat/shared_invite/zt-rl30zw00-obL1Hr1q1ATvkzVkFp8S0Q" class="buttons" target="_blank">Slack</a>
</p>
<br /><br />
<a href="https://join.slack.com/t/codeigniterchat/shared_invite/zt-rl30zw00-obL1Hr1q1ATvkzVkFp8S0Q" class="buttons cta-btn" target="_blank">Visit Slack Channel</a>
</div><!--inner-page-text-box ends here-->

<div class="clr"></div>
Expand All @@ -76,11 +72,10 @@ class="link-primary" target="_blank">signup</a> for it :)
<p>
GitHub issues are also used for tracking planned and approved enhancements, often tied in to specific releases.
</p>
<p>
<a href="https://github.com/bcit-ci/CodeIgniter/" class="buttons" target="_blank">CodeIgniter 3</a>
<a href="https://github.com/codeigniter4/codeigniter4/" class="buttons" target="_blank">CodeIgniter 4</a>
</p>
<br /><br />

<a href="https://github.com/bcit-ci/CodeIgniter/" class="buttons cta-btn" target="_blank">CodeIgniter 3</a>
<a href="https://github.com/codeigniter4/codeigniter4/" class="buttons cta-btn" target="_blank">CodeIgniter 4</a>

</div><!--inner-page-text-box ends here-->

<div class="clr"></div>
Expand Down
31 changes: 31 additions & 0 deletions public/assets/css/ci-theme.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2124,3 +2124,34 @@ html.dark-theme #discuss-icon-holder {
html.dark-theme #discuss-icon {
fill: rgba(221, 72, 20, 0.9);
}

.inner-page-text-box {
padding: 32px;
}

.cta-btn {
margin: 0;
float: none;
display: inline-block;
}

.cta-btn:not(:first-of-type) {
margin-left: 1rem;
}

ul li {
margin-top: 1rem;
line-height: 1em;
}

.warning {
padding: 10px 32px;
}

p {
line-height: 1.5em;
}

.inner-page-text-box {
margin: 32px auto;
}