Pure FP8 (W8A8) GEMM support (draft) #306
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdeng5
changed the title
|
This requirements from framework team, provide a prototype for framework team, they expect to evaluate scaled W8A8 bases on this interface. |
t4c1
reviewed
Apr 14, 2025
Comment on lines
380
to
389
| // 32 x 64 | ||
| if constexpr(!is_same_v<CopyOpR2G_, XE_2D_U32x8x16_ST_N>) { | ||
| auto D = make_tensor(make_gmem_ptr(params.ptr_D), make_layout(make_shape(4096, 4096), make_stride(4096, 1))); | ||
| for(int i = 0; i < size<1>(accumulators); i++) { | ||
| for(int j = 0; j < size<2>(accumulators); j++) { | ||
| for(int v = 0; v < size<0>(accumulators); v++) { | ||
| D(v + i * 8 + m_sg * 32 + BlockIdxY() * 256 , BlockIdxX() * 256 + n_sg * 64 + (thread_idx % 16) * 2 + (j % 2) + (j / 2) * 32) = accumulators(v, i, j); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This looks really ugly here. Is there any good reason not to implement it as a new copy atom?
There was a problem hiding this comment.
I think you are right. UniveralCopy will be OK for this copy atom. But I did not figure it out yet
mehdi-goli
reviewed
Apr 14, 2025
mehdi-goli
reviewed
Apr 14, 2025
|
This is a draft version. I will polish the code ASAP |
jiyang1011
force-pushed
the
jiyang/fp8
branch
2 times, most recently
from
7ab624a to
eb3529e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently hard code to store the result collective/xe_epilogue.hpp
and example pvc_gemm_fp8.cpp