feat: format report_task tool call for codex #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Preview binaries are ready! To test with modules: |
johnstcn
reviewed
Jan 13, 2026
Comment on lines
+54
to
+55
| msg += "\n" // This handles the case where the message ends with a tool call | ||
| lines := strings.Split(msg, "\n") |
Member
There was a problem hiding this comment.
This smells to me like it could be instead handled by finding a start of a tool call and treating reaching the end of lines as a signal to use that as the end index.
| } else if toolCallStartIdx != -1 && line == "{\"message\": \"Thanks for reporting!\"}" { | ||
| // Store [start, end] pair | ||
| // trim all the remaining empty lines after tool call | ||
| for idx+1 < len(lines)-1 { |
Member
There was a problem hiding this comment.
Could we not find all "start" and "end" indices in a single loop iteration?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description