Skip to content

chore: clean up mock upstream in integration tests #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pawbana merged 2 commits into from
Feb 27, 2026
Merged

chore: clean up mock upstream in integration tests #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea82069
chore: clean up mock upstream in integration tests
pawbana Feb 24, 2026
2fbb149
review 1: fixtures.Files -> fixtures.Fixture rename + getters require…
pawbana Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions apidump_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import (
"github.com/coder/aibridge/mcp"
"github.com/coder/aibridge/provider"
"github.com/stretchr/testify/require"
"golang.org/x/tools/txtar"
)

func openaiCfgWithAPIDump(url, key, dumpDir string) config.OpenAI {
Expand Down Expand Up @@ -92,16 +91,9 @@ func TestAPIDump(t *testing.T) {
ctx, cancel := context.WithTimeout(t.Context(), time.Second*30)
t.Cleanup(cancel)

arc := txtar.Parse(tc.fixture)
files := filesMap(arc)
require.Contains(t, files, fixtureRequest)
require.Contains(t, files, fixtureNonStreamingResponse)

reqBody := files[fixtureRequest]

// Setup mock upstream server.
srv := newMockServer(ctx, t, files, nil, nil)
t.Cleanup(srv.Close)
fix := fixtures.Parse(t, tc.fixture)
srv := testutil.NewMockUpstream(t, ctx, testutil.NewFixtureResponse(fix))

// Create temp dir for API dumps.
dumpDir := t.TempDir()
Expand All @@ -117,7 +109,7 @@ func TestAPIDump(t *testing.T) {
}
mockSrv.Start()

req := tc.createRequestFunc(t, mockSrv.URL, reqBody)
req := tc.createRequestFunc(t, mockSrv.URL, fix.Request())
resp, err := http.DefaultClient.Do(req)
require.NoError(t, err)
require.Equal(t, http.StatusOK, resp.StatusCode)
Expand Down Expand Up @@ -163,7 +155,7 @@ func TestAPIDump(t *testing.T) {
require.NoError(t, err)

// Compare requests semantically (key order may differ).
require.JSONEq(t, string(dumpBody), string(reqBody), "request body JSON should match semantically")
require.JSONEq(t, string(dumpBody), string(fix.Request()), "request body JSON should match semantically")

// Verify response dump contains expected HTTP response format.
respDumpData, err := os.ReadFile(respDumpFile)
Expand All @@ -177,7 +169,7 @@ func TestAPIDump(t *testing.T) {
require.NoError(t, err)

// Compare responses semantically (key order may differ).
expectedRespBody := files[fixtureNonStreamingResponse]
expectedRespBody := fix.NonStreaming()
require.JSONEq(t, string(expectedRespBody), string(dumpRespBody), "response body JSON should match semantically")

recorderClient.VerifyAllInterceptionsEnded(t)
Expand Down
Loading