Closed
Conversation
Fixes changes made to the "vscode/build/gupfile.reh.js" file, such as the rename and file content changes
Member
|
Thank you for tackling this! Looks like the VS Code submodule still needs to be updated, or at least I am not seeing it in the commits. We need to make sure to refresh all the patches as well, in case you have not done that yet. Also is that the right commit? Looks like 1.106.0 should be microsoft/vscode@ac4cbdf |
Author
|
Yeah, you're right. The 1.106.0 release still uses the "*.js" format for gulpfiles My apologies, I created a PR off the wrong branch. I was working with the latest VSCode commit on this branch when I encountered this issue I'll close this PR since I created one with the actual VSCode 1.106.0 submodule update #7562 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes changes made to the "vscode/build/gupfile.reh.js" file, such as the rename and file content changes
This stems from this vscode commit: microsoft/vscode@723aa84