Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: download mutagen binary into resources #103

Merged
merged 20 commits into from
Mar 12, 2025
Merged

ci: download mutagen binary into resources #103

merged 20 commits into from
Mar 12, 2025
+54 −6

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Mar 10, 2025 •
edited
Loading

Closes #60

@ethanndickson Graphite App
Copy link
Member Author

ethanndickson commented Mar 10, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson mentioned this pull request Mar 10, 2025
Merged
1 task
@ethanndickson ethanndickson force-pushed the ethan/mutagen-lifecycle branch from 3384471 to 7f92c54 Compare March 10, 2025 03:02
@ethanndickson ethanndickson force-pushed the ethan/ci-mutagen-binary branch 9 times, most recently from 9d37e45 to b3fa35f Compare March 10, 2025 07:02
ThomasK33
ThomasK33 reviewed Mar 10, 2025
View reviewed changes
@ethanndickson ethanndickson force-pushed the ethan/ci-mutagen-binary branch from b3fa35f to ac08c30 Compare March 10, 2025 10:30
ThomasK33
ThomasK33 reviewed Mar 10, 2025
View reviewed changes
@ThomasK33
Copy link
Member

We should probably update the gitignore to include the three mutagen files.

ThomasK33
ThomasK33 reviewed Mar 10, 2025
View reviewed changes
@ethanndickson ethanndickson marked this pull request as ready for review March 11, 2025 03:02
@ethanndickson ethanndickson linked an issue Mar 11, 2025 that may be closed by this pull request
Bundle Mutagen binary in App Bundle #60
Closed
@ethanndickson ethanndickson force-pushed the ethan/ci-mutagen-binary branch from d633084 to b5fe325 Compare March 11, 2025 03:46
deansheather
deansheather reviewed Mar 11, 2025
View reviewed changes
@ethanndickson ethanndickson self-assigned this Mar 11, 2025
@ethanndickson ethanndickson force-pushed the ethan/ci-mutagen-binary branch from 4435a3e to 4c4245e Compare March 11, 2025 05:27
matifali
matifali approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

ThomasK33
ThomasK33 reviewed Mar 11, 2025
View reviewed changes
@ethanndickson ethanndickson force-pushed the ethan/ci-mutagen-binary branch from 4c4245e to a3c9f08 Compare March 11, 2025 09:42
@ethanndickson ethanndickson force-pushed the ethan/mutagen-lifecycle branch from 1d0a6e1 to ad1b24d Compare March 12, 2025 02:30
@ethanndickson ethanndickson force-pushed the ethan/ci-mutagen-binary branch from e0822be to d0ef9b5 Compare March 12, 2025 02:31
@ethanndickson ethanndickson mentioned this pull request Mar 12, 2025
Open
@ethanndickson Graphite App
Copy link
Member Author

ethanndickson commented Mar 12, 2025 •
edited
Loading

Merge activity

  • Mar 12, 1:43 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Mar 12, 1:44 AM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 12, 1:46 AM EDT: A user merged this pull request with Graphite.

@ethanndickson ethanndickson changed the base branch from ethan/mutagen-lifecycle to graphite-base/103 March 12, 2025 05:43
@ethanndickson ethanndickson changed the base branch from graphite-base/103 to main March 12, 2025 05:43
@ethanndickson ethanndickson force-pushed the ethan/ci-mutagen-binary branch from ec9576b to 52d8876 Compare March 12, 2025 05:44
@ethanndickson ethanndickson merged commit 93e7a8f into main Mar 12, 2025
4 checks passed
@ethanndickson ethanndickson deleted the ethan/ci-mutagen-binary branch March 12, 2025 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasK33 ThomasK33 ThomasK33 left review comments

@matifali matifali matifali approved these changes

@deansheather deansheather deansheather approved these changes

Assignees

@ethanndickson ethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bundle Mutagen binary in App Bundle
4 participants
@ethanndickson @ThomasK33 @matifali @deansheather