Skip to content

chore(pkgbuild): delete existing app during preinstall, spctl --assess during postinstall #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 18, 2025
Merged

chore(pkgbuild): delete existing app during preinstall, spctl --assess during postinstall #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d32974
chore(pkgbuild): delete existing app during preinstall, `spctl --asse…
ethanndickson Mar 13, 2025
db36d6d
spctl assess extesnsion
ethanndickson Mar 13, 2025
5c1ba77
typo
ethanndickson Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pkgbuild/scripts/postinstall
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
RUNNING_MARKER_FILE="/tmp/coder_desktop_running"
VPN_MARKER_FILE="/tmp/coder_vpn_was_running"

# Before this script, or the user, opens the app, make sure
# Gatekeeper has ingested the notarization ticket.
spctl -avvv "/Applications/Coder Desktop.app"
# spctl can't assess non-apps, so this will always return a non-zero exit code,
# but the error message implies at minimum the signature of the extension was
# checked.
spctl -avvv "/Applications/Coder Desktop.app/Contents/Library/SystemExtensions/com.coder.Coder-Desktop.VPN.systemextension" || true

# Restart Coder Desktop if it was running before
if [ -f "$RUNNING_MARKER_FILE" ]; then
echo "Starting Coder Desktop..."
Expand Down
7 changes: 7 additions & 0 deletions pkgbuild/scripts/preinstall
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,11 @@ echo "Asking com.coder.Coder-Desktop to quit..."
osascript -e 'if app id "com.coder.Coder-Desktop" is running then' -e 'quit app id "com.coder.Coder-Desktop"' -e 'end if'
echo "Done."

APP="/Applications/Coder Desktop.app"
if [ -d "$APP" ]; then
echo "Deleting Coder Desktop..."
rm -rf "$APP"
echo "Done."
fi

exit 0
Loading