feat: add XPC communication to Network Extension #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I implemented communication updates from the NetworkExtension to the App, but it doesn't seem like the network extension is ever fully starting up. I see that it's being started, but never see any logs in |
|
The somewhat good news is that error log is from the Speaker trying to read the start response from the tunnel. You're not seeing the logs in |
ethanndickson
approved these changes
Jan 30, 2025
Comment on lines
48
to
49
| // TODO: better init maybe? kinda wonky | ||
| lazy var xpc = VPNXPCInterface(vpn: self) |
There was a problem hiding this comment.
I think this is fine, since it's a chicken & egg problem. The alternative is to use an optional, probably with ! - lazy lets us skip the unwrap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.