-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Sign in Window views & view models #20
Conversation
6e80e71
to
0daea96
Compare
0daea96
to
1980713
Compare
App/SignInTokenPage.xaml
Outdated
Orientation="Horizontal" | ||
HorizontalAlignment="Center" | ||
Spacing="10"> | ||
<Button Content="Back" HorizontalAlignment="Right" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the better way of doing forwards/backwards navigation is to use a <RootFrame>
in the window rather than setting Window.Content
directly.
One pitfall that might make it hard to use the RootFrame's built-in navigation stuff is that I don't think it lets you instantiate the Window types yourself - which makes it hard to get a ViewModel in there.
In the TrayWindow code in my PR, I ended up just setting RootFrame.Content
directly because of this limitation (and because I don't need forwards/backwards navigation). But if you could get that working it'd be more idiomatic I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I switched it to using a Frame so we're not just touching the window content directly, but I'm not using the forward/backwards functionality yet because of the aforementioned issue.
In the future if we solve it, we could have the "Coder Desktop" text and the navigation buttons be on the Window itself, rather than in each page.
Adds views for the Sign In dialog window, and a backing view model.
This is still a bit rough around the edges, but I'd like to get some eyes on it and merge to iterate.
It also needs to be integrated with some of the structural changes in #19 including dependency injection. That can happen per or post merge, depending on when #19 lands in
main
.Known issues: