feat: installer and uninstaller #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Minor, but we use a flat black icon on macOS from the presskit. You very rarely see this app/executable icon during normal usage on either OS though.
There was a problem hiding this comment.
Atif commented on the icon in Slack and I said it's something we can fix after we get alpha out, pretty much just involves someone designer-y redoing all of the assets in that dir + the coder.ico and banner BMP in the coder/coder repo for the old installer.
I think for these icons we want something with a background, like maybe a black square with a white icon or something. Otherwise it'll look weird on the wrong system light/dark theme.
sreya
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new package
Installerwhich uses WixSharp to build WixToolset installers for WIndows.We build two installers:
Coder Desktop (Core), which installs the app files, service files, VPN files (wintun.dll), creates a system service and an app shortcut in the start menuCoder Desktop, which will netinstall the .NET runtime if it's not installed and then chain install `Coder Desktop (Core)We will only be shipping the
Coder Desktopinstaller, which contains the Core installer. The chained Core installation doesn't show up in Settings > Apps.Follow-up PR will integrate to CI and add authenticode signing to the installer binaries.
Closes #11
Closes #30