feat: show vpn start/stop failure in app #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spikecurtis
approved these changes
Mar 6, 2025
| [NotifyPropertyChangedFor(nameof(ShowWorkspacesHeader))] | ||
| [NotifyPropertyChangedFor(nameof(ShowNoAgentsSection))] | ||
| [NotifyPropertyChangedFor(nameof(ShowAgentsSection))] | ||
| [NotifyPropertyChangedFor(nameof(ShowFailedSection))] |
There was a problem hiding this comment.
ShowFailedSection doesn't depend on the lifecycle.
It really is annoying that we have to maintain these deps this way, where you have to mark the dependency, not the dependent. Harder to verify it's correct.
There was a problem hiding this comment.
Yeah I definitely don't like it either. Since it's a decorator attribute I wonder if someone could write an inverse version of this using codegen or something. Maybe one already exists and I've just been doing it the dumb way
There was a problem hiding this comment.
Thanks for spotting this though!
deansheather
commented
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds red text that appears when the VPN fails to start or stop. After an error, any manual start/stop operation will clear the error.
Changes a lot of the optional components (
TextBlocks, etc.) in the tray window to use bools for visibility rather than custom converters, because the logic behind whether to show them is slightly more complicated now. I could've maybe rearranged the app and shifted everything around into multiple parent containers for each condition that we check but it seemed harder than just using bools on the view model.Most of the lines in this PR were from restructuring the XAML to make it simpler (and unindenting many lines in the process).
Contributes to #40