feat: add logging to App #78
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
spikecurtis
force-pushed
the
spike/app-logging
branch
from
86b541a to
5e1ba1d
Compare
spikecurtis
force-pushed
the
spike/app-logging
branch
from
5e1ba1d to
37ee7e4
Compare
| private const string ConfigSubKey = @"SOFTWARE\Coder Desktop\App"; | ||
| private const string logFilename = "app.log"; | ||
| #else | ||
| private const string MutagenControllerConfigSection = "DebugAppMutagenController"; | ||
| private const string ConfigSubKey = @"SOFTWARE\Coder Desktop\DebugApp"; | ||
| private const string logFilename = "debug-app.log"; |
There was a problem hiding this comment.
Can these just be Coder Desktop and Coder Desktop Debug or something instead, rather than changing the existing key?
There was a problem hiding this comment.
We can do Coder Desktop Debug\App instead of Coder Desktop\DebugApp --- but I do want App to be its own key to keep it distinct from the VPN service. Things like Serilog have defined config they understand, and I think we will want to have separate control over the app and the VPN service.
There was a problem hiding this comment.
Yeah I didn't put two and two together about the serilog stuff, so your way is better. I don't particularly mind what key we use then, but the service keys should probably be fixed in this PR too to match the new format
There was a problem hiding this comment.
Any log configuration for the app should go in HKEY_CURRENT_USER though IMO
There was a problem hiding this comment.
The Mutagen binary path still kinda needs to live in HKLM, since it's set by the installer. I've made it so that it starts with default config, hardcoded into the app, then checks HKLM, then HKCU.
spikecurtis
force-pushed
the
spike/app-logging
branch
from
8b98bba to
41cf916
Compare
Adds logging to the Coder Desktop application.