feat: add workspace app icons to tray window #86
Conversation
- Adds AgentAppViewModel to handle each button - Adds collapsible control components to handle the collapsing section - Adds Uuid type to work around issues with the built-in Guid type - Adds ModelMerge utility for merging lists with minimal updates to work around constant flashing in the UI
|
|
||
| public partial class CoderApiClient | ||
| { | ||
| public Task<WorkspaceAgent> GetWorkspaceAgent(string id, CancellationToken ct = default) |
There was a problem hiding this comment.
This would be safer if we accepted a UUID, rather than a string, which could totally change the endpoint we hit.
There was a problem hiding this comment.
I considered this but didn't want to add a dependency between CoderSdk and Vpn.Proto, and adding a new project for just a UUID type seems overkill. The Go codersdk package accepts string IDs for some methods as well, so I think it's fine.
There was a problem hiding this comment.
I had (wrongly) assumed/remembered that we parsed the Agent protobufs into a model with Guid id types. But, we just leave it as a byte string. You're right, not worth introducing the dep.
There was a problem hiding this comment.
Could we move our Uuid implementation to CoderSdk? There will likely be plenty of times we want to interact with UUIDs outside of the protobuf protocols.
|
|
||
| public partial class CoderApiClient | ||
| { | ||
| public Task<WorkspaceAgent> GetWorkspaceAgent(string id, CancellationToken ct = default) |
There was a problem hiding this comment.
Could we move our Uuid implementation to CoderSdk? There will likely be plenty of times we want to interact with UUIDs outside of the protobuf protocols.
Vpn.Proto/Uuid.cs
Outdated
| /// 4122 compliance, but it should provide enough coverage for Coder | ||
| /// Desktop. | ||
| /// </summary> | ||
| public class Uuid |
There was a problem hiding this comment.
Can we move this to CoderSdk?
|
I suggested we move |
AgentAppViewModelto handle each buttonUuidtype to work around issues with the built-inGuidtypeModelMergeutility for merging lists with minimal updates to work around constant flashing in the UITODO:
ModelMergeAgentAppViewModelsince I don't think they do anything$SESSION_TOKENreplacementKnown issues:
/icon/cursor.svgseems to be an SVG with an embedded PNG, which I guess can't be rendered properly by WinUIbuttons.mp4
Closes #50