Impl: icons with support for light&dark themes #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Start button is active even though it doesn't do anything when clicked when the workspace template has updates. - resolves #31
- to `Update and start` to reflect that the it also starts the workspace - more consistent with the web client
- LAF support in Toolbox is quite primitive, it turns out icon support for light and dark themes is enabled by a masked flag on the icons - the mask flag controls whether the svg colors are inverted in light&dark themes.
matifali
requested changes
Mar 11, 2025
| @@ -78,7 +78,7 @@ class CoderRemoteEnvironment( | |||
| workspace = workspace.copy(latestBuild = build) | |||
| update(workspace, agent) | |||
| }, | |||
| Action(context.i18n.ptrl("Update"), enabled = { workspace.outdated }) { | |||
| Action(context.i18n.ptrl("Update and start"), enabled = { workspace.outdated }) { | |||
There was a problem hiding this comment.
We use "Update and restart" on the web dashboard if the workspace is already in a Running state.
And "Update and start" if the workspace is Stopped
So, we need to handle both cases separately.
Also, instead of disabling, can we just hide the unavailable actions?
There was a problem hiding this comment.
Sure I think we can do both though I'm not sure how do I get to have a running workspace but outdated so that I can test and play with it.
In the meantime let me write two issues to capture the requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Among other things we also fixed and issue with the
Startbutton which remained active when a workspace was stopped and outdated. In order to be more consistent with the web client we renamed the button toUpdate and startto reflect that it also starts the workspace.